Elevate-Lab / elevate-lab-website

A website to inform and invite contributors to elevate-lab

https://elevate-lab.github.io/elevate-lab-website/

MIT License

18 stars 64 forks source link

added event page #146

Closed garvitchittora closed 4 years ago

garvitchittora commented 4 years ago

Pull Request

Proposed Changes

added event page
Fixes #102
SS

Checklist:

[X] My code follows the Mentioned Guidelines for the project
[X] I have self-reviewed the changes made
[X] I have made the changes easy to understand by adding comments
[X] My changes does not generate new warnings/errors
[X] I have attached relevant screenshots to display the changes made
[X] I have made the required changes to the documentations

garvitchittora commented 4 years ago

@Tlazypanda @deepakDOTexe @tejma17 plz review :)

tejma17 commented 4 years ago

Hello @garvitchittora, Past Events section is looking a bit compressed 😅. Also, I don't think we need to specify the venue for past events. Can you improve the design accordingly? Moreover, Past events will stack up as we proceed further. Consider it while designing.

garvitchittora commented 4 years ago

for stack up, we can use pagination for that.

tejma17 commented 4 years ago

Yeah. Just improve past events cards.

garvitchittora commented 4 years ago

after changes @tejma17

Screenshot (377)

tejma17 commented 4 years ago

@garvitchittora one more suggestion 😅. It would be better if the date and View Event button are in the same row.

garvitchittora commented 4 years ago

@tejma17

Screenshot (379)