Elevate-Lab / elevate-lab-website

A website to inform and invite contributors to elevate-lab
https://elevate-lab.github.io/elevate-lab-website/
MIT License
18 stars 64 forks source link

fix mixed content error for google fonts #212

Closed chuckyroh closed 3 years ago

chuckyroh commented 3 years ago

Pull Request

Fixes #211

Proposed Changes

Types of changes made

<!-- google fonts start -->
    <link 
      href="https://fonts.googleapis.com/css2?family=Poppins:ital,wght@0,400;0,500;0,600;0,700;0,800;0,900;1,400;1,500;1,600;1,700;1,800;1,900&family=Racing+Sans+One&display=swap"
      rel="stylesheet"
    />
<!-- google fonts end -->

Screenshots

Checklist:

chuckyroh commented 3 years ago

It's not much of a screenshot. There's no errors (just a log message about the light or dark mode)

image

All I added was the below line to the head of each html file.

<!-- google fonts start -->
    <link 
      href="https://fonts.googleapis.com/css2?family=Poppins:ital,wght@0,400;0,500;0,600;0,700;0,800;0,900;1,400;1,500;1,600;1,700;1,800;1,900&family=Racing+Sans+One&display=swap"
      rel="stylesheet"
    />
<!-- google fonts end -->
Tlazypanda commented 3 years ago

Hey @chuckyroh I meant the fonts in the issue you had mentioned some fonts were not loading due to this error so now how are they rendering? :sweat_smile:

chuckyroh commented 3 years ago

Oh, sorry about that, I'll add them.

I realized just now though that the fonts were already being applied (my brain thought it changed).

I thought I had seen a change but style.css also imports the same google font. This might actually be a another issue. The css import is not needed if it's imported in the .

I can fix that one if you want me too.