Open bravadomizzou opened 8 years ago
I added support for DataTables, still need to include webpack and get it checked out by others before merging. Waiting on development of others before committing node modules for DataTables and other dependencies to avoid conflicts.
Note to self: Update the Contributing Wiki after this is merged as to how to use Yarn.
Should I go ahead and merge this into master?
I'm very much looking forward to the availability of these features in Dewdrop.
It would be nice if we had a CI system that would support feature branches to aid in determining whether the related changes are stable and ready for merging.
Perhaps this feature branch is already being successfully used by one or more projects?
I'm also curious if any projects that are not using the DataTables functionality successfully operate using this feature branch, or if there are any backward incompatibilities or risks that should be addressed?
@darbyfelton I am not aware of any project using this currently, there should not be any backwards compatibility issues.
We may want to put in the release notes how to enable these new features:
To enable DataTables in your application:
For entire application:
Pimple::getInstance()['listing-handler'] = new Listing\DataTables();
For a component:
public function getListing()
{
if (!this->listing) {
$this->listing = new Listing($adminListing, $primaryKey, $request, new Listing\DataTables();
}
return $this->listing;
}
I found an issue when using this with listings that have bulk selections. So that will need to be updated before merging.
Also need to add support for SortableListingInterface. Currently it just shows the sort index, not the sorting grabber.
This is the work for #61