ElfFriend-DnD / foundryvtt-compactBeyond5eSheet

A character sheet built with the intention of mimicing the dndbeyond character sheet layout and UX
MIT License
14 stars 16 forks source link

Currency Conversion & Missing Buttons #58

Open bearsy1 opened 3 years ago

bearsy1 commented 3 years ago

Great work with the module and the sheet looks nice!

The first one is a very small issue but the currency conversion button, the one that looks like a pair of coins, doesn't seem to do anything with the compact DnD Beyond sheet selected. However, when I go back to the standard 5e sheet, the button works as expected, converting all coinage to the highest possible.

Also for other modules that add buttons near the currency conversion button, they probably won't/don't show up. One specific module that I'm running into this issue with is the Give Item to Another Player module (https://github.com/Sepichat/FoundryVTT-GiveItem). This module adds a button near items to make them tradeable to other players in addition to a button near the currency field to make coinage tradeable as well. The trade item button is unaffected but the trade currency button is entirely missing with the compact DnD Beyond sheet. Not sure if there are any such other instances where buttons like this don't show up, but for now with the modules my setup is using, this is what I have noticed so far.

Any effort to try and rectify this would be appreciated! Keep up the good work!