[Feature request] Consider using DAE apply effect function when DAE is installed and active

ElfFriend-DnD / foundryvtt-item-effects-to-chat-5e

A module which allows a GM to interact with effects on rolled items from chat.

MIT License

0 stars 2 forks source link

[Feature request] Consider using DAE apply effect function when DAE is installed and active #1

Closed mech-tools closed 2 years ago

mech-tools commented 2 years ago

Hello,

A lot of foundry users use DAE/Times Up.

Using DAE apply effect function would also make use of the special DAE fields such as:

Force display on token
Stackable (especially this one)
Special duration

The DAE function is: https://gitlab.com/tposney/dae/-/blob/master/src/module/dae.ts#L1331

akrigline commented 2 years ago

I believe all of the data from the origin effect is transferred to the target tokens, I wouldn't have expected the DAE data to rely on a specific application.

I'll take a look to double check that. I'm not terribly interested in doing any module detection to change application behavior but I might be convinced otherwise upon investigation

mech-tools commented 2 years ago

@akrigline Might be only for the Stackable option if not for the rest. I tested that. With DAE application, it's ok, but not with this module.

mech-tools commented 2 years ago

@akrigline Sorry, didn't mean to close the issue -_-