Closed ElfSundae closed 6 years ago
It seems like $this->option('characters') targeting Illuminate\Console\Command::option() can also be of type array; however, ElfSundae\Laravel\Hashid...enerateRandomAlphabet() does only seem to accept string, maybe add an additional type check?
see https://scrutinizer-ci.com/g/ElfSundae/laravel-hashid/inspections/77523947-fb53-423e-bed4-490ff611ea6e/issues/files/src/Console/AlphabetGenerateCommand.php?status=new&orderField=path&order=asc&honorSelectedPaths=0&issueId=23996809#inspectioncomment-89146709
It seems like $this->option('characters') targeting Illuminate\Console\Command::option() can also be of type array; however, ElfSundae\Laravel\Hashid...enerateRandomAlphabet() does only seem to accept string, maybe add an additional type check?
see https://scrutinizer-ci.com/g/ElfSundae/laravel-hashid/inspections/77523947-fb53-423e-bed4-490ff611ea6e/issues/files/src/Console/AlphabetGenerateCommand.php?status=new&orderField=path&order=asc&honorSelectedPaths=0&issueId=23996809#inspectioncomment-89146709