search

ElgSoft / ElgEditorScripting

ElgEditorScripting is an Unreal Engine 5 editor only plugin created to extend the possibilities of Editor Utility Widgets.
MIT License
202 stars 35 forks source link

Make the plugin build with warnings as errors and without unity build #16

Closed vegolasse closed 3 months ago

vegolasse commented 3 months ago

Added missing include files to define types properly. It luckily happens to work with unity builds, but we have a CI step which does static code analysis and doesn't use unity to catch missing include errors like this.

Also, the #endif that previously (correctly) was an #else causes an "unreachable code" error to appear since WITH_EDITOR will have two return statements after each other.

vegolasse commented 3 months ago

I saw that this is very similar to the "Update to 5.4" PR. If that's merged, there's only one file left to fix and I can make a new PR with that unless you fix it directly.

vegolasse commented 3 months ago

Closing as there was a similar PR already