search

ElgarL / GroupManager

The original permission plug-in for Spigot/Bukkit.
https://elgarl.github.io/GroupManager/
GNU General Public License v3.0
80 stars 36 forks source link

[BUG] Creating multiple worlds #27

Closed AsVaidas closed 4 years ago

AsVaidas commented 4 years ago

Describe the bug Don't know why (even if you tested it), but when loading a world, groupmanager created config files for those worlds

To Reproduce Upload the newest version to the server Restart the server Go to the island Method to load the world: https://pastebin.com/GuvNTgwE image image

Does not happen in v2.6

Expected behavior Because the config states, that all unnamed worlds should get the config from main world, it shouldn't create the new config for the world

Please complete the following information: OS: debian 10 (buster) image image Config: https://pastebin.com/twvfvFnG

Additional context No errors

Gave the 5 stars review just because bugs don't go to review section and I love GroupManager and the improvements that you did to it

ElgarL commented 4 years ago

I tested this with Multiverse and could not reproduce it. Its extremely odd as no code changes have been made to any of the mirroring code. Can you first, check your config.yml and ensure you do have all_unnamed_worlds in there. Secondly show me the section of the log where GM detects the new world. It should mention mirroring.

AsVaidas commented 4 years ago

I tested this with Multiverse and could not reproduce it. Its extremely odd as no code changes have been made to any of the mirroring code. Can you first, check your config.yml and ensure you do have all_unnamed_worlds in there. Secondly show me the section of the log where GM detects the new world. It should mention mirroring.

Config: https://pastebin.com/twvfvFnG

It's strange, because groupmanager didn't show anything about new world. After installing v2.6, then it shows at the end https://pastebin.com/rAUvpXVU

ElgarL commented 4 years ago

Can you delete your config and let it generate a new one. There have been some changes to the config defaults. Perhaps its causing issues with missing nodes.

AsVaidas commented 4 years ago

Yes, from what I can see, if users won't delete their config before updating, they will have this problem

ElgarL commented 4 years ago

I'm guessing an exception is being thrown and not seen in the config loading. Breaking it before the mirrors loads. I've not seen it as I'm always using a current config. I'll do some digging.