search

ElgarL / GroupManager

The original permission plug-in for Spigot/Bukkit.
https://elgarl.github.io/GroupManager/
GNU General Public License v3.0
80 stars 36 forks source link

Scope disconnected players. #93

Closed kyllian-vssr closed 2 years ago

kyllian-vssr commented 2 years ago

Is your feature request related to a problem? Please describe. No, not on this plugin, but yes, caused by this plugin. This plugin does not check the permissions of disconnected/logging out players, so you can't hide the logout message with one of the more popular plugins (EssentialsX - Issue here).

Describe the solution you'd like The possibility for GroupManager to manage, target disconnected players. I also assume as said in the above issue that it will require Vault.

Additional context The two three reasons I use GM instead of another permission plugin is that I am used to using this permission plugin since 1.8. And that despite this little issue that doesn't bother me that much, I admit that I would love to see this feature. Moreover, it is very easy to use and understand.

Oh and I'm not a Java developer, or even any developer... Otherwise I would have liked to contribute.

I'm really sorry I don't have any code to share. 🙄❤️

Hopefully this feature request will be applied soon! :D

ElgarL commented 2 years ago

Sorry I don't understand this ticket. A Player logging out has the same permissions as he has when connected. At the point of him disconnecting he still has those same permissions. I have posted on the EssentialsX ticket for clarification too.

Can you give precise directions on how to replicate this issue?

ElgarL commented 2 years ago

I have done some digging and this is clearly an Essentials bug. Vault/GroupManager both report the correct permissions for a player joining/leaving. In both instances the Player is online with a valid Player object (before the join message is sent). Essentials is, for some reason, not clearing the quit message.

Default user with no real permissions to monitor join/quit. default player

Op user joining with all permissions. op with all perms

ElgarL commented 2 years ago

I'm going to close this as it is an Essentials bug. I've given them the information about it, where the bug is, and how to fix it. https://github.com/EssentialsX/Essentials/issues/1677#issuecomment-1243613547

ElgarL commented 2 years ago

I have pushed a fix to GroupManager pre-release. This will fix the compatibility issue with EssentialsX silent vanish.