search

Elgg / community_plugins

Elgg community plugin repository
17 stars 16 forks source link

Discussions #92

Closed ewinslow closed 10 years ago

ewinslow commented 10 years ago

Submitted in behalf of @beck24 so I can comment

beck24 commented 10 years ago

This solves a number of issues that are already ticketed and haven't been referenced in commit messages: https://github.com/Elgg/community_plugins/issues/69 https://github.com/Elgg/community_plugins/issues/42 https://github.com/Elgg/community_plugins/issues/27 https://github.com/Elgg/community_plugins/issues/26

ewinslow commented 10 years ago

Did you want to rebase -i and add those to the relevant commits or just close the tickets manually?

ewinslow commented 10 years ago

This LGTM by the way. It's clearly an improvement and I don't want to slow you down. We're not distributing an API so I think we can be more lax in how we update this code.

beck24 commented 10 years ago

OK, I'll just close those tickets manually. I'm not going to add any more features/fixes to this as it's already a huge update. Other ones can come in new PRs after this is merged.