search

EliAndrewC / sideboard

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Sphinx's conf.py should gets its version from its plugin #15

Closed EliAndrewC closed 8 years ago

EliAndrewC commented 10 years ago

The conf.py generated by Sphinx has the lines

version = '0.1'
release = '0.1'

The core Sideboard version of this code looks like

__here__ = os.path.abspath(os.path.dirname(__file__))
execfile(os.path.join(__here__, '..', '..', 'sideboard', '_version.py'))
release = version = __version__

We should do the same thing in plugins (with the plugin name substituted for 'sideboard').

robdennis commented 10 years ago

Reminder if we want single source 2 and 3 support we can't use execfile

On Mon, Mar 24, 2014 at 6:44 PM, Eli Courtwright notifications@github.com wrote:

The conf.py generated by Sphinx has the lines

version = '0.1'
release = '0.1'

The core Sideboard version of this code looks like

__here__ = os.path.abspath(os.path.dirname(__file__))
execfile(os.path.join(__here__, '..', '..', 'sideboard', '_version.py'))
release = version = __version__

We should do the same thing in plugins (with the plugin name substituted for 'sideboard').

Reply to this email directly or view it on GitHub: https://github.com/appliedsec/sideboard/issues/15

EliAndrewC commented 8 years ago

Fixed in current version.