What's the deal with filter_distribute_modules?

[EliAndrewC]

The filter_distribute_modules function enumerates a specific list of modules which should not be imported in each plugin. We need to review

• why this code exists, at a glance I'm not 100% sure why it's there
• whether we can replace it with just a prefix check, e.g. instead of enumerating 'setuptools', 'setuptools.archive_util', 'setuptools.command', 'setuptools.command.alias', etc we could just say 'setuptools' and then not import any module which starts with that
• what can we replace this with if possible, or just add a docstring or other comment explaining what this code is doing

[robdennis]

This was to make the checked in virtualenv tests in the top level test directory pass . Frank would know for sure.

On Mon, Mar 24, 2014 at 6:58 PM, Eli Courtwright notifications@github.com wrote:

The filter_distribute_modules function enumerates a specific list of modules which should not be imported in each plugin. We need to review

• why this code exists, at a glance I'm not 100% sure why it's there
• whether we can replace it with just a prefix check, e.g. instead of enumerating 'setuptools', 'setuptools.archive_util', 'setuptools.command', 'setuptools.command.alias', etc we could just say 'setuptools' and then not import any module which starts with that

* what can we replace this with if possible, or just add a docstring or other comment explaining what this code is doing

Reply to this email directly or view it on GitHub: https://github.com/appliedsec/sideboard/issues/23