search

EliAndrewC / sideboard

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

tox and travis support #36

Closed robdennis closed 10 years ago

robdennis commented 10 years ago

Even if this is really just 2.7 for now, it's a better base to go forward

robdennis commented 10 years ago

the work here was done in #38

@EliAndrewC can you follow the instructions here? Particularly part about turning on the webhook, as you're the only repo admin.

EliAndrewC commented 10 years ago

I've turned on the webhook and also specifically marked sideboard as being "on" in the Travis UI. I think that should do it - if memory serves, pull requests should automatically have travis run the unit tests and let us know whether they pass or fail before we accept the pull request.

robdennis commented 10 years ago

38 shows that travis is in action

robdennis commented 10 years ago

from an email conversation with @EliAndrewC

So what happened in the tests was this:

I guess we could reimplement the addCleanup pattern at the class level for tearDownClass to avoid this cascading failure, but that doesn't address the core problem of why we can't connect to localhost:8282 on Travis.

What I'll do in the short term is add a check to see if we can just open a regular socket connection to localhost:8282 so that if we can't then it's a Travis issue like that's not okay, and if we can but the websocket connection fails then it's a websocket specific issue.

it appears as if localhost worked good

EliAndrewC commented 10 years ago

To clarify, the issue turned out to be that we were binding to 0.0.0.0 but connecting to localhost. Travis correctly treats the former as an IPv4 address, but treats localhost as an IPv6 address. The solution was to try to connect to 127.0.0.1 instead of localhost and everything started working.