fixes #28

[EliAndrewC]

Is there some way I can edit the pull request to not display angular or angular-mocks? I included them in the tests directory because karma uses them.

Ah well, I'm very happy with this overall. I'll try to leave some specific comments on various parts.

[EliAndrewC]

I messed up the rebase; I meant to merge all 4 commits into 1 but it looks like I somehow merged them into 2 commits. That will be less easy to review, so I'll try again.

[robdennis]

Don't think you can exclude files from the review, I'll try and look tonight. Nice one

On Sat, Apr 12, 2014 at 3:26 PM, Eli Courtwright notifications@github.com wrote:

Is there some way I can edit the pull request to not display angular or angular-mocks? I included them in the tests directory because karma uses them. Ah well, I'm very happy with this overall. I'll try to leave some specific comments on various parts. You can merge this Pull Request by running: git pull https://github.com/EliAndrewC/sideboard master Or you can view, comment on it, or merge it online at: https://github.com/appliedsec/sideboard/pull/50 -- Commit Summary --

• This is a combination of 3 commits.

• WebSocketService with documentation and karma tests -- File Changes -- M .gitignore (4) M development-defaults.ini (3) M docs/source/index.rst (226) M sideboard/configspec.ini (12) M sideboard/lib/_cp.py (2) M sideboard/lib/_websockets.py (6) M sideboard/server.py (8) D sideboard/static/.gitkeep (0) A sideboard/static/angular/sideboard.js (280) M sideboard/tests/test_websockets.py (4) M sideboard/websockets.py (2) A tests/karma/deps/angular-1.2.16.js (21464) A tests/karma/deps/angular-mocks-1.2.16.js (2163) A tests/karma/karma.conf.js (70) A tests/karma/sideboardSpec.js (413) -- Patch Links -- https://github.com/appliedsec/sideboard/pull/50.patch https://github.com/appliedsec/sideboard/pull/50.diff

  Reply to this email directly or view it on GitHub: https://github.com/appliedsec/sideboard/pull/50