search

EliAndrewC / sideboard

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

mounting webapps fails on CherryPy 3.2.5 #54

Closed EliAndrewC closed 10 years ago

EliAndrewC commented 10 years ago

@robdennis recently upgraded our CherryPy to be 3.2.5 in order to get it to run on Travis. Unfortunately, there's a CherryPy bug in 3.2.3 and later where it requires a bytestring rather than a unicode string be passed to mount: https://bitbucket.org/cherrypy/cherrypy/issue/1285

As it happens, we are already monkeypatching mount to provide better error handling; we can also implement a workaround for this by encoding the first parameter to force it to be non-unicode.

EliAndrewC commented 10 years ago

This is actually required to have a working Sideboard system, and I actually just downgraded on my development box in order to be able to do development on the past few tickets. So I should probably push out an actual fix before too long. Since I'm planning on making another pull request on Wednesday for #13, I'll make a pull request for this as well.