EliAndrewC / sideboard

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Change default RPC mechanism to websockets #8

Closed EliAndrewC closed 10 years ago

EliAndrewC commented 10 years ago

We currently use jsonrpc as the default RPC mechanism, but we should make websockets the default. This is especially important in cases where a Javascript client wants to subscribe to something and shouldn't need to know or care on what box the plugin actually lives.

When we do this, we should also update the Subscription class to no longer need a URL but instead merely specify a method.

EliAndrewC commented 10 years ago

After spending a little time on this, it seems like it would be easiest to make a bunch of changes all at once, because they're all interconnected, so I'd want to make the changes already listed, as well as the following:

robdennis commented 10 years ago

I like this approach

EliAndrewC commented 10 years ago

A few other changes:

I've implemented most of this and updated the documentation for the most part, so I'll probably make a pull request tonight.

EliAndrewC commented 10 years ago

I'm not ready for a pull request yet, but if someone wants a sneak peek at the refactor, here's a link to the commit in my forked repo: https://github.com/EliAndrewC/sideboard/commit/4ab9318a7d6bd3ccd603fa3ed1bc660e20dc4aa4

Overall very little will change, except that there are a few more optional methods and attributes and keyword arguments to functions. The main API improvement is to the Subscription class, which is way simpler now.