search

EliCDavis / polyform

Immutable mesh processing library
https://elicdavis.gitbook.io/polyform/
MIT License
79 stars 6 forks source link

Add error wrapping in the obj package #34

Closed alexykot closed 3 months ago

alexykot commented 3 months ago

Add error wrapping throughout the obj package, to help debugging.

I came across an oddly formed .obj file, a product of conversion from STL by some online converter, and it is failing to parse. Debugging that turned out to be very difficult without wrapping as it was just strconv.Atoi: parsing "": invalid syntax message with no details of what, where or why. This PR fixes that.

alexykot commented 3 months ago

I've fixed parsing as well. That branch is based on this one so I'll rebase and PR the fix after this is merged.

EliCDavis commented 3 months ago

This is great! Thanks!