4주차 개발 내용 Merge Request - [merged]

[PromotezCitizen]

In GitLab by @HanSanghyeon on Oct 25, 2024, 17:18

Merges develop -> master

[PromotezCitizen]

In GitLab by @mumunuu on Oct 28, 2024, 11:48

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/category/controller/CategoryAdminController.java line 22

id를 의미있는 변수명으로 하시기 바랍니다.

[PromotezCitizen]

In GitLab by @mumunuu on Oct 28, 2024, 11:48

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/category/controller/CategoryAdminController.java line 29

category 생성하는 다른 API와 body에 타입등을 받아서 API 통합을 하시기 바랍니다.

[PromotezCitizen]

In GitLab by @mumunuu on Oct 28, 2024, 11:48

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/category/controller/CategoryAdminController.java line 36

dto 객체는 보통 클래스명으로 그대로 따라서 씁니다.

[PromotezCitizen]

In GitLab by @mumunuu on Oct 28, 2024, 11:48

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/exception/ex_orderItem/OrderItemExceptionHandler.java line 23

String 통신이 아닌, JSON 통신으로 일관성있게 통신하기

[PromotezCitizen]

In GitLab by @mumunuu on Oct 28, 2024, 11:48

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/order/service/OrderService.java line 156

c가 무엇을 의미하나요?ㅎㅎ

[PromotezCitizen]

In GitLab by @mumunuu on Oct 28, 2024, 11:48

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/orderitem/controller/OrderItemController.java line 26

상수처리. 의미없는 내용 바디에 담지 않기 no content 같은것등이 있음

[PromotezCitizen]

In GitLab by @mumunuu on Oct 28, 2024, 11:48

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/review/service/ReviewService.java line 54

하드코딩하지말고 상수값으로 관리

[PromotezCitizen]

In GitLab by @HanSanghyeon on Oct 28, 2024, 21:12

mentioned in commit ec251a40b54985fb7cc5b7c2c5c04211f004cbe8