search

Elice-Track-Cloud-4-HanSH / buy-gurus-back

0 stars 0 forks source link

Develop - [merged] #85

Closed PromotezCitizen closed 3 weeks ago

PromotezCitizen commented 1 month ago

In GitLab by @Cloud4-Na-Yong-Jin on Oct 13, 2024, 22:49

Merges develop -> master

PromotezCitizen commented 1 month ago

In GitLab by @mumunuu on Oct 13, 2024, 23:17

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/email/EmailService.java line 29

5가 뭔가요? 이런것을 매직넘버라고 하는데 숫자로만 적어놔서 5라는 기능이 어떤것을 하는지 모르는 것을 의미합니다.
안좋은 코드 습관중에 하나구요. int 변수명 = 5; 를 통해서 정의하시기 바랍니다. 오른쪽처럼요.

PromotezCitizen commented 1 month ago

In GitLab by @mumunuu on Oct 13, 2024, 23:17

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/email/EmailService.java line 56

DTO validator 에서 처리했어야 합니다.

PromotezCitizen commented 1 month ago

In GitLab by @mumunuu on Oct 13, 2024, 23:17

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/email/EmailService.java line 31

매직 넘버 상수처리하기

PromotezCitizen commented 1 month ago

In GitLab by @mumunuu on Oct 13, 2024, 23:17

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/exception/ex_user/ex/CodeExpiredException.java line 6

글로벌 에러 핸들러 만들어서 에러 메세지도 상수화 처리하기

PromotezCitizen commented 1 month ago

In GitLab by @mumunuu on Oct 13, 2024, 23:17

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/exception/GlobalExceptionHandler.java line 14

이런식으로 하면 되는데 어느분은 이렇게 하시고, 아직 팀 내에서 공통화가 안된 모양이죠?

PromotezCitizen commented 1 month ago

In GitLab by @mumunuu on Oct 13, 2024, 23:17

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/jwt/filter/JwtAuthenticationFilter.java line 54

...?

PromotezCitizen commented 1 month ago

In GitLab by @mumunuu on Oct 13, 2024, 23:17

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/jwt/filter/JwtAuthenticationFilter.java line 84

시큐리티를 다시 보셔야할거 같아요. filter를 skip하는 URL 검증은 이렇게 하지 않습니다.

PromotezCitizen commented 1 month ago

In GitLab by @mumunuu on Oct 13, 2024, 23:17

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/user/controller/UserController.java line 48

정보를 다시 반환해줘도 무방해요.

PromotezCitizen commented 1 month ago

In GitLab by @Cloud4-Na-Yong-Jin on Oct 15, 2024, 08:37

Commented on buy-gurus-b/src/main/java/com/team04/buy_gurus/email/EmailService.java line 29

changed this line in version 2 of the diff

PromotezCitizen commented 1 month ago

In GitLab by @Cloud4-Na-Yong-Jin on Oct 15, 2024, 08:37

added 2 commits

Compare with previous version

PromotezCitizen commented 1 month ago

In GitLab by @HanSanghyeon on Oct 15, 2024, 13:16

mentioned in commit 931a662a596358a99cd4202c791b557a4a1b60cb