search

Elico-Corp / odoo-docker

Simple yet powerful Odoo image for Docker based on OCB code and maintained by Elico Corporation.
https://hub.docker.com/r/elicocorp/odoo/
GNU Lesser General Public License v3.0
77 stars 93 forks source link

missing 'POSTGRES_DB=postgres' to docker-compose.yml example #126

Closed patleb closed 2 years ago

patleb commented 5 years ago

It might be needed for other examples, but I didn't test other scenarios yet.

patleb commented 5 years ago

Related to this issue https://github.com/Elico-Corp/odoo-docker/issues/123.

elicoidal commented 5 years ago

@seb-elico ?

seb-elico commented 5 years ago

@patleb Thanks for the suggestion. If I'm correct, this is the default value. We have never used it and it works fine, so not necessary IMO. Closing this issue, feel free to provide more details though!

CC @elicoidal

patleb commented 5 years ago

I'm using postgres 11 and odoo 12 on ubuntu and it was for the introductory example where there is not much configuration. Also, if you create a specific db user for odoo (as suggested in the other examples), you won't have this issue.

I merely applied the solution suggested here and this is pretty much the same behavior for the issue https://github.com/Elico-Corp/odoo-docker/issues/123. So, unless you know what the issue was about, I'm quite sure that this was the same problem brought up.

Also, postgres might be the default db name, but I'm guessing that the recent images of postgres don't differentiate when the config is missing (which suggests that it might be mandatory or a bug has been introduced recently).

I don't really mind that you close the PR, I was just sharing what I did to make your docker-compose.yml example work on my side.