[IMP][10.0] Fix permissions

[seb-elico]

Before merging this PR, the image can be tested by pulling: docker pull sebelico/odoo-docker:10.0-fix-permissions

This PR contains:

• [IMP] mapping with the host user (environment variable TARGET_ID)
• [REF] move startup.sh to sources folder for consistency
• [REF] move scripts folder for consistency with the folder structure inside the container
• [FIX] when no addons to download, the grep function was failing in the boot script due to the ^ char. We created a Python script to workaround this issue, but actually it works if the grep is run in another bash script (see FIXME in no_addons.sh)
• [IMP] create a function to replace the parameters in odoo.conf (will be useful if we plan to add new environment variable for the parameter substitution)
• [IMP] dynamic setup of SSH key
• [IMP] start the startup.sh script before doing any operation with odoo user
• [IMP] ssh and scripts folders/volumes can belong to target user on the host
• [FIX] It's now possible to specify a branch in ADDONS_REPO using the same syntax as oca_dependencies.txt
• [IMP] Allow multiple addons repos download from an oca_dependencies.txt file at the root of the additional_addons folder rather than using env variable ADDONS_REPO
• [IMP] Added roadmap in README.md

[seb-elico]

@Elico-Corp/docker-reviewers please review :+1:

@victormartinelicocorp @Zhouhao12345 @RawEvan @Wizr feel free to comment!

[seb-elico]

@elicoidal before we merge this PR, I will pull sebelico/odoo-docker:10.0-fix-permissions on Superman and use it for all our v10 trunk instances, so that we have a little more REX about the new version, since there are a lot of changes (I just want to make sure we won't break anything)

@victormartinelicocorp @Zhouhao12345 @RawEvan @Wizr feel free to comment!

[elicoidal]

Later on we need to sit down to coordinate the changes you made and the installation script

[seb-elico]

@elicoidal I found a bug in the new image: when the volumes are not mapped (I think extra_addons, sessions and odoo_data), they will be created by Docker in its internal folders (e.g. /var/lib/docker/volumes) as anonymous volumes. But they will belong to root:root, meaning that odoo user (1000:1000) will not be able to write inside (which is a big issue for the sessions and attachments). Workaround is to map those volumes in d-c.yml and make sure the folders belong to 1000:1000, but I definitely need to fix this before we merge!

[elicoidal]

I hit this bug during the week endÉric CaudalOn Jun 12, 2017 7:26 PM, Sébastien Maillard - Elico Corp notifications@github.com wrote:@elicoidal I found a bug in the new image: when the volumes are not mapped (I think extra_addons, sessions and odoo_data), they will be created by Docker in its internal folders (e.g. /var/lib/docker/volumes) as anonymous volumes. But they will belong to root:root, meaning that odoo user (1000:1000) will not be able to write inside (which is a big issue for the sessions and attachments). Workaround is to map those volumes in d-c.yml and make sure the folders belong to 1000:1000, but I definitely need to fix this before we merge!

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

[seb-elico]

@elicoidal all ownership bugs are fixed, I also fixed the download of repo when specifying the branch in d-c.yml (e.g. - "ADDONS_REPO=git@github.com:Elico-Corp/yugong-odoo.git 10.0"). Last but not least, I implemented the download of multiple repositories using a local oca_dependencies.txt file. Refer to the PR description for full list of changes.

Still need to pull the image on my laptop and Superman for the final tests before we merge.

@victormartinelicocorp @Zhouhao12345 @RawEvan @Wizr feel free to comment! :+1:

[seb-elico]

@victormartinelicocorp @Zhouhao12345 @RawEvan @Wizr any feedback?

[seb-elico]

@elicoidal all tests are successful and image has been running on our test servers for several days now. I think it's time to merge this PR and backport it to v7~9. Unless @victormartinelicocorp @Zhouhao12345 @RawEvan @Wizr have some feedback, but they didn't reply for the last 13 days now

[elicoidal]

Go ahead @seb-elico

[victormmtorres]

@elicoidal all tests are successful and image has been running on our test servers for several days now. I think it's time to merge this PR and backport it to v7~9. Unless @victormartinelicocorp @Zhouhao12345 @RawEvan @Wizr have some feedback, but they didn't reply for the last 13 days now

@seb-elico Talking by me. Here on this PR there is many commands that ever seem so for review need to study, so I feel this PR is good enough as you tested. But I could not say I understand everything you fix.

[seb-elico]

@RawEvan thanks for your comments, please check my answers! @elicoidal all comments have been answered, let me know when it's merged so that I can backport to previous versions