search

Elijas / auto-youtube-subscription-playlist-2

Script automatically adds videos to playlists from Youtube channels and/or subscriptions (Youtube Collections alternative).
MIT License
249 stars 54 forks source link

Timezone support #67

Closed JesperDramsch closed 4 years ago

JesperDramsch commented 4 years ago

Following the time shenanigans in #66 I implemented full timezone support.

Instead of UTC, GMT offset is used.

Adresses #35

Fabian42 commented 4 years ago

Are you sure that you fully implemented timezones? https://www.youtube.com/watch?v=-5wpm-gesOY (That's an entertaining video explaining the insanity of timezones, I recommend watching it just for fun, even if it might not be very helpful for this case.)

JesperDramsch commented 4 years ago

Never 😅

But we're getting the timezones from Google and passing them to google. What's the worst that can happen? Nervous laugh

victorjzsun commented 4 years ago

@JesperDramsch merged #66, please resolve conflict

victorjzsun commented 4 years ago

@JesperDramsch close this since you have an updated PR?

JesperDramsch commented 4 years ago

They're different PRs though.

Victor Sun notifications@github.com schrieb am Mi., 22. Apr. 2020, 20:17:

@JesperDramsch https://github.com/JesperDramsch close this since you have an updated PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Elijas/auto-youtube-subscription-playlist-2/pull/67#issuecomment-617978288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAT7XHAA6C3RJ77W6LJSTADRN47GBANCNFSM4KXMCFBA .

victorjzsun commented 4 years ago

Ok, just one comment then: https://github.com/Elijas/auto-youtube-subscription-playlist-2/pull/72#discussion_r413245303

JesperDramsch commented 4 years ago

@victorjzsun ok

victorjzsun commented 4 years ago

https://github.com/Elijas/auto-youtube-subscription-playlist-2/pull/72#discussion_r413245303 references the issue of changing the timezone within the script settings

JesperDramsch commented 4 years ago

Thanks for the screengrab. Added it to the readme