Elinvention / gnome-shell-extension-nasa-apod

Change your wallpaper daily to the NASA's astronomy picture of the day
https://extensions.gnome.org/extension/1202/nasa-apod/
GNU General Public License v3.0
119 stars 21 forks source link

Image explanation now never shown #40

Closed biji closed 3 years ago

biji commented 3 years ago

Describe the bug

Image explanation now never shown, in notification and in indicator

A clear and concise description of what the bug is.

To Reproduce

new image downloaded, image explanation show nothing

Expected behavior

image explanation shown

Screenshots

If applicable, add screenshots to help explain your problem.

Operating system with version

Fedora 34

GNOME Shell version

40

Installation method

Logs <- VERY IMPORTANT

Please paste below the relevant parts of journalctl -f -o cat /usr/bin/gnome-shell. If you don't use systemd, you have to find where the logs are stored and paste them here.

Extension's settings

Some errors might be triggered by a spefic set of settings. The command below outputs all of the extension settigs that were changed from the default value.

If you installed the extension system-wide (e.g. from AUR or distro packages) the command is:
gsettings --schemadir /usr/share/gnome-shell/extensions/nasa_apod@elinvention.ovh/schemas/schemas/ list-recursively org.gnome.shell.extensions.nasa-apod.

Otherwise it is:
gsettings --schemadir ~/.local/share/gnome-shell/extensions/nasa_apod@elinvention.ovh/schemas/ list-recursively org.gnome.shell.extensions.nasa-apod.

Elinvention commented 3 years ago

I can't reproduce this. You should properly fill the template with all the required information to help me understand what's going on.

biji commented 3 years ago

Extension's settings

org.gnome.shell.extensions.nasa-apod background-options 'default'
org.gnome.shell.extensions.nasa-apod image-resolution 'hd'
org.gnome.shell.extensions.nasa-apod pinned-background ''
org.gnome.shell.extensions.nasa-apod screensaver-options 'default'
org.gnome.shell.extensions.nasa-apod image-resolution-metered 'lowres'
org.gnome.shell.extensions.nasa-apod refresh-metered false
org.gnome.shell.extensions.nasa-apod notify true
org.gnome.shell.extensions.nasa-apod hide false
org.gnome.shell.extensions.nasa-apod set-background true
org.gnome.shell.extensions.nasa-apod download-folder '/home/----/Pictures/wallpaper/'
org.gnome.shell.extensions.nasa-apod last-refresh uint64 1628138189669
org.gnome.shell.extensions.nasa-apod api-keys ['cJgMcxbg8KSWR0ocScILopzXWz50QzfeNFOZEfAH']
org.gnome.shell.extensions.nasa-apod last-json "{\"copyright\":\"Eduardo Schaberger Poupeau\",\"date\":\"2021-08-05\",\"explanation\":\"South is up in this detailed telescopic view across the Moon's rugged southern highlands. Captured on July 20, the lunar landscape features the Moon's young and old, the large craters Tycho and Clavius. About 100 million years young, Tycho is the sharp-walled 85 kilometer diameter crater near center, its 2 kilometer tall central peak in bright sunlight and dark shadow. Debris ejected during the impact that created Tycho still make it the stand out lunar crater when the Moon is near full, producing a highly visible radiating system of light streaks, bright rays that extend across much of the lunar near side. In fact, some of the material collected at the Apollo 17 landing site, about 2,000 kilometers away, likely originated from the Tycho impact.  One of the oldest and largest craters on the Moon's near side, 225 kilometer diameter Clavius is due south (above) of Tycho. Clavius crater's own ray system resulting from its original impact event would have faded long ago. The old crater's worn walls and smooth floor are now overlayed by smaller craters from impacts that occurred after Clavius was formed. Observations by the Stratospheric Observatory for Infrared Astronomy (SOFIA) published in 2020 found water at Clavius. Of course both young Tycho and old Clavius craters are lunar locations in the science fiction epic 2001: A Space Odyssey.\",\"hdurl\":\"https://apod.nasa.gov/apod/image/2108/Luna-Tycho-Clavius-high.jpg\",\"media_type\":\"image\",\"service_version\":\"v1\",\"title\":\"Tycho and Clavius\",\"url\":\"https://apod.nasa.gov/apod/image/2108/Luna-Tycho-Clavius-high1024.jpg\"}\n"
org.gnome.shell.extensions.nasa-apod transient true
org.gnome.shell.extensions.nasa-apod set-lock-screen true

No notification after downloaded and panel only display this: image

Thanks

Elinvention commented 3 years ago

Thanks that's better, but not enough yet. I need the gnome shell's logs that you can read with journalctl -f -o cat /usr/bin/gnome-shell.

Elinvention commented 3 years ago

I reproduced this bug on my laptop where I have notifications enables. This is the error:

JS ERROR: Error: Expected type string for argument 'property_name' but got type GObject_Object
notify@/home/elia/.local/share/gnome-shell/extensions/nasa_apod@elinvention.ovh/notifications.js:27:12
_notifyAPIResults@/home/elia/.local/share/gnome-shell/extensions/nasa_apod@elinvention.ovh/extension.js:294:23
wrapper@resource:///org/gnome/gjs/modules/script/_legacy.js:83:27
_download_image/<@/home/elia/.local/share/gnome-shell/extensions/nasa_apod@elinvention.ovh/extension.js:516:22