search

Elite-Kode / eddbapi

A REST API for EDDB
Apache License 2.0
9 stars 3 forks source link

Troubles getting body type name filtering to work #3

Closed Rukus308 closed 5 years ago

Rukus308 commented 7 years ago

First off, nice work creating an API around the EDDB data, very handy and extremely needed as the JSONL file sizes for things like planetary body information is huge.

If I use the "http://elitebgs.kodeblox.com/api/eddb/v1/bodies" API endpoint, to get all the system bodies for say Quince, it works well and returns all the expected bodies, however when I try and take the body name type from the JSON response and add the "bodytypename" parameter to the URL to filter bodies by type, I always get nothing back.

I'm assuming that one should be able to list only bodies of a certain type in a specific system if both "systemname" and "bodytypename" paramters are used. Does that sound right? would you have a working URL example to prove its user error on my part? could this be a bug or something not fully implemented on the API?

Thanks in advance

SayakMukhopadhyay commented 7 years ago

Welp! Its a bug. And it seems to be a stupid one at that. I will fix it.

Rukus308 commented 7 years ago

Thanks for looking into this, much appreciated!

Rukus308 commented 7 years ago

Any idea when you might be able to implement a fix for this?

SayakMukhopadhyay commented 7 years ago

I am planning to release the stuff I am working on by this weekend (22nd at most). I will get to it as soon as I complete it. Sorry for the inconvenience.

Rukus308 commented 7 years ago

Cheers for the heads up on ETA.