search

Elite-Kode / elitebgs

BGS tracking tool for Elite Dangerous
https://elitebgs.app/
Apache License 2.0
59 stars 10 forks source link

States displayed on Systems page should show system-specific states #371

Closed 00Chaotic closed 1 year ago

00Chaotic commented 1 year ago

The Systems page seems to show the faction-wide state rather than the state of a faction within a specific system. It may be better for the information on the Systems page to remain specific to that system, and the faction-wide information can remain on the Factions page.

I'll use my faction as an example.

One of our members was looking at the Kuwema system when they noticed that the page said our faction was at war. However, this is because we're at war in a different system. The below chart for Kuwema shows that our faction has been at war since 10 March, which is correct, but it's a war in a different system.

image

I'm willing to take a look into this, but wanted to raise an issue here first to get others' thoughts.

Is there a reason for that design decision? Are there reasons not to make this change?

SayakMukhopadhyay commented 1 year ago

What you are looking for is the Active State that is also listed.

00Chaotic commented 1 year ago

Is there a reason for the other State to be present on the Systems page? Perhaps it would be better placed in the Factions page and/or re-naming the charts would help clarify which ones show general faction states and which are specific to the system in question.

SayakMukhopadhyay commented 1 year ago

Its there for legacy reasons. Also, frontier still provides the information for some reason and hence I continue to show it, Anyway, what you see is intended.

00Chaotic commented 1 year ago

Alright, feel free to close this ticket if no changes are intended to be made.