EliteMasterEric / EnigmaEngine

A fork of FNF's Kade Engine that combines its QoL features with true mod support and new gameplay enhancements
https://enigmaengine.github.io/
Other
12 stars 1 forks source link

Bug Report: ALL KNOWN `NULL OBJECT REFERENCES` (NORs) #71

Open isakube opened 2 years ago

isakube commented 2 years ago

Please check for duplicates, similar issues or closed issues with the same problem, as well performing simple troubleshooting steps (such as deleting the export folder if it's an issue with compiling, reinstalling Enigma Engine) before submitting an issue.

If you are playing a downloaded version of the game, what operating system are you using?

Windows (x86), Windows (x86_64), Linux, or macOS? Specify below. macOS

What version of the game are you using? Look in the bottom left corner of the main menu.

0.3.0-54593a4

Have you identified any steps to reproduce the bug? If so, please describe them below. Use images if possible.

1: Return to Menu from Gameplay

To reproduce:

Enter any song, pause, and select Return To Menu. This will cause a NOR at FlxSound.hx:592, which means the volume of the music cannot update.

2: Return To Menu from Results Screen

To reproduce:

Complete any song, and press Enter on the results screen. This will cause a NOR at ResultsSubState.hx:236, which means the music in the Results Screen cannot fade out.

Contributingeth To This Liste

FORMAT (copy):

## Basic summarization of where the `NOR` happens. NOT the code position though. See above examples.

### To reproduce:
Add ways the reproduce this `NOR` here. Also add the code position in the format `{SOURCEFILE}:{LINE}`, where SOURCEFILE is the HX file where the `NOR` occurs, and LINE is the line on which the `NOR` occurs.

how

Copy the above template and fill out the title and To Reproduce sections in a comment. When the NOR is confirmed, it will be added to the above list.

"Is this too much? Do you need to sit down?" - that one gnome from the pilot episode of Gravity Falls
ghost commented 2 years ago

you can either remove the polymod from the project.xml file or you can use this https://github.com/JonnyboyTheboy/old-polymod which is the polymod that fixes it not trying to self promo

EliteMasterEric commented 2 years ago

I didn't think this bug is related to Polymod?

What does your repo change? You recreated the repo instead of cloning or forking so I can't see the commit history

ghost commented 2 years ago

sorry i used your old polymod that the object null was used so i only have the download version of it

ghost commented 2 years ago

i could take it down

ghost commented 2 years ago

if you want me too