search

Elius94 / react-photo-sphere-viewer

Photosphere Viewer for React.JS
MIT License
69 stars 21 forks source link

[Support]: Adding different 3D arrow models to the Virtual Tour Plugin and changing their vertical position #42

Closed hakan-berat closed 11 months ago

hakan-berat commented 11 months ago

What are you trying to do?

Hi,

I am developing an web application using this library and the Virtual Tour Plugin, but I have not been able to customize the 3D arrow models and give specific values to their vertical position. Can you provide information on how I can do this?

Best Regards

Library Version

3.4.0-psv5.4.0

What operating system are you using?

macOS

What browser are you using?

Chrome

Elius94 commented 11 months ago

Hi! Thanks for your issue, but I have to close it because it's related to the main library photo-sphere-viewer by Damien Sorel. Consider to ask him on his repo. Thanks

Elius94 commented 10 months ago

Hey! The only way Is to fork also my repo and use It as local lib. Of course Is not really comfortable for the mainteinment of your project. I suggest to make a PR on the main lib with a custom prop or method to change the Arrow model. This should be a nice improvement for photo-sphere-viewer. Thanks

Il gio 28 dic 2023, 20:22 Mete Çözer @.***> ha scritto:

Hello again

In the main library we customized the 3D arrow and put our own model and it worked very well. After forking the main library and putting the arrow we customized, we want to use the arrow we customized through this React library. How can we give a path the library we forked in this library.

— Reply to this email directly, view it on GitHub https://github.com/Elius94/react-photo-sphere-viewer/issues/42#issuecomment-1871433956, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRXUU72O23AZI4C3EYTNK3YLXBIRAVCNFSM6AAAAABATC3FLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZRGQZTGOJVGY . You are receiving this because you modified the open/close state.Message ID: @.***>

hakan-berat commented 10 months ago

Hey,

I'm sorry to have taken up your time. I don't think I'm talented enough to contribute to an open source project yet, but I will definitely try to realize this idea in the future. I'm interested in the idea of being able to fork and use both repos, would you mind explaining the milestones of this process in general?