EliverLara / Ant

:ant: A flat and light theme with a modern look
https://www.gnome-look.org/p/1099856/
GNU General Public License v3.0
818 stars 41 forks source link

Nautilus visual bugs on path bar #61

Closed JuanCAlpizar closed 5 years ago

JuanCAlpizar commented 5 years ago

Hey there, I've found two small issues with nautilus path bar using GNOME 3.30.

The first one is related to how the path bar looks on the background. First, this is how it looks while it's on the foreground using the nebula version:

image

As you can see the current folder highlights in a light blue color.

This is how it looks when it's on the background

image

As you can see, a weird square surrounds the currently selected folder in the path bar, which doesn't look so nice.

The second issue is related to the context menu on the path bar. If you click the current folder, a popup menu will display, but it will remove the highlight color for the currently selected directory on the path bar and the color won't come back up until you click again the currently selected directory on the path bar.

image

Please let me know if you need any further information about it, thanks :D

JuanCAlpizar commented 5 years ago

About the first issue can you check if adding this rule will help with it? I'm entirely new to theme design, got the class playing with the gtk inspector and I don't know if the class is specific enough or on the other hand it's overkill:

.nautilus-window .titlebar .horizontal .horizontal .background.frame.horizontal.path-bar-box .path-bar .horizontal:last-child .flat.text-button.toggle{
 background-color: rgba(0,0,0,0);
}
EliverLara commented 5 years ago

Hi, thanks for reporting, right now I can't reproduce the issue, since my gnome version is not the most recent, I'm waiting for the fedora update to get gnome 3.30 and then update the theme.

About testing your theme development, you can clone this repository and run npm i && gulp, this will install the development dependencies and then you'll be able to modify the .scss files, the gulp command will be responsible for recompiling the files and updating the theme on the fly, if theme is not updating automatically you will have to do it on your own.

JuanCAlpizar commented 5 years ago

@EliverLara well I performed a more archaic method: I just opened the gtk.css under the gtk3.20 folder, added the class, restarted the shell and re-applied the theme. In my case, it looks good now but I can't guarantee any backward compatibility.

image

I guess I'll leave it as is until you can validate it and eventually close the issue when is solved on the repo. Thanks :)