EliverLara / Nordic

:snowflake: Dark Gtk3.20+ theme created using the awesome Nord color pallete.
GNU General Public License v3.0
2.25k stars 112 forks source link

Gnome 43.1 support #237

Open sekhm opened 1 year ago

sekhm commented 1 year ago

I recently attempted to install the Nordic theme for Gnome 43.1, however I encountered some odd behavior with Nautilus and many other programs with a similar interface: several button listings are not properly rendered.

Screenshot from 2022-11-16 21-54-08

Additionally, this occurs when I go Settings > About. Screenshot from 2022-11-16 21-57-47

I noticed that when I attempt to launch Nautilus using Firefox in a file uploading form, the Nautilus window is correctly prompted.

Screenshot from 2022-11-16 22-01-21

ventoux84 commented 1 year ago

Hello, I also run Archlinux and i installed Nordic from Gnome-look. I can't have as good a result as you in Gnome-shell windows. The settings window is white or a bad brown. The same thing for Nautilus. Capture-d-cran-du-2022-11-18-09-46-16 It's ok with olds apps.

Which link did you follow for download or install the theme ?

oleg-rom commented 1 year ago

The same thing happened in my instance of arch linux and fedora 37. Basically it is a common problem with all themes - they all have some artifacts on the new version of Gnome DE. All themes need to be adjusted, as probably something changed in how they use gtk4 now. I hope this theme will be adjusted.

sekhm commented 1 year ago

Which link did you follow for download or install the theme ?

I installed it from gnome-look.

Sang-Buster commented 1 year ago

The same thing happened in my instance of arch linux and fedora 37. Basically it is a common problem with all themes - they all have some artifacts on the new version of Gnome DE. All themes need to be adjusted, as probably something changed in how they use gtk4 now. I hope this theme will be adjusted.

Right, I had to run a python script from libadwaita-theme-changer and reboot my computer, and it worked finally!

servet commented 1 year ago

The same thing happened in my instance of arch linux and fedora 37. Basically it is a common problem with all themes - they all have some artifacts on the new version of Gnome DE. All themes need to be adjusted, as probably something changed in how they use gtk4 now. I hope this theme will be adjusted.

Right, I had to run a python script from libadwaita-theme-changer and reboot my computer, and it worked finally!

This solution not worked for me.

Hello, I also run Archlinux and i installed Nordic from Gnome-look. I can't have as good a result as you in Gnome-shell windows. The settings window is white or a bad brown. The same thing for Nautilus. Capture-d-cran-du-2022-11-18-09-46-16 It's ok with olds apps.

Which link did you follow for download or install the theme ?

Same issue with manjaro. Did you find any solution?

Liameternal commented 1 year ago

I have the same problem with fedora37, gnome43. style doen not apply to file manger and settings, chrome, telegram Screenshot from 2023-01-28 17-49-24 Screenshot from 2023-01-28 17-49-40 Screenshot from 2023-01-28 17-48-24 the python script from libadwaita-theme-changer just solve settings rending problem, but others remain. Is this a bug? or is there any other solution? Thanks in advance!

pirey commented 1 year ago

I have the similar problem as well. I'm using Nixos with gnome 43.2 image as you can see, the theme is set properly on the gnome tweak app, but not in calculator and file manager. I'm not sure how to debug the issue

ventoux84 commented 1 year ago

I switched to Plasma for the same theme. All ok.

Cryolitia commented 1 year ago

I have the similar problem as well. I'm using Nixos with gnome 43.2 image as you can see, the theme is set properly on the gnome tweak app, but not in calculator and file manager. I'm not sure how to debug the issue

{
    ......
    home.sessionVariables = {
        GTK_THEME = "Nordic";
        QT_STYLE_OVERRIDE="Nordic";
    };
}

in your home.nix if ure using home-manager

see https://github.com/NixOS/nixpkgs/issues/85135

Cryolitia commented 1 year ago

I have the same problem on NixOS Unstable with Gnome 44.1 image

sysinfo

 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.31, NixOS, 23.11 (Tapir), 23.11pre491650.7409480d5c8`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.3`
 - channels(cryolitia): `""`
 - channels(root): `"home-manager, nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

the version of nordic I use https://github.com/NixOS/nixpkgs/blob/a865f0b136dbbc99d7e77cfcf85de6c2ff7a235b/pkgs/data/themes/nordic/default.nix

plus, I got these outputs when opening nautilus

(org.gnome.Nautilus:7389): Gtk-WARNING **: 17:34:46.938: Theme parser error: gtk.css:5626:3-9: No property named "height"

(org.gnome.Nautilus:7389): Gtk-WARNING **: 17:34:46.981: Theme parser error: gtk.css:5626:3-9: No property named "height"

(org.gnome.Nautilus:7389): Gtk-WARNING **: 17:34:52.078: AdwGizmo 0x10c2960 (tabboxchild) reported min width -6, but sizes must be >= 0

(org.gnome.Nautilus:7389): Gtk-WARNING **: 17:34:52.177: AdwGizmo 0x10c2960 (tabboxchild) reported min width -6, but sizes must be >= 0

duplicate #216

EliverLara commented 1 year ago

@Cryolitia this is odd, I tried to reproduce the issue in a similar environment in a VM but everything looks fine:

Before applying gtk4 styles:

Captura desde 2023-06-21 12-40-40

After aplying gtk4 styles:

Captura desde 2023-06-21 12-55-42

Have you faced similar issues with another themes?

cenunix commented 11 months ago

could you please tell us how you applied the themes @EliverLara

Edit: I believe I have found the issue, if you take a look at the source for the nordic package in nixpkgs. it isn't even copying any gtk-4.0 folders over. I would assume this will cause issues for anyone using NixOS and the nordic package. I will attempt to fix this and then submit a pr to nixpkgs. https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/data/themes/nordic/default.nix

Cryolitia commented 10 months ago

https://github.com/Cryolitia/nixos-config

This is my NixOS profiles, and the issue happend on all of my two devices.

aacebedo commented 7 months ago

@EliverLara how did you solve this issue? I still have the same issue on nixos 23.11

svanschu commented 6 months ago

I have similar problems on Manjaro

grafik

grafik

brumik commented 5 months ago

Anybody solved the problem here? I am on a fresh nixos setup and both unstable and stable nordic theme has the same problem as the original post. I would also love to see which config worked in the VM.

Edit: I got this working manually copying the ccs from Nordic40 in both gtk4 and gtk3 forlders in .config and moving the 'assets' to the config folder. So I expect that the NixOS package is out of date (or the post processing script is not correct maybe?)

Edit2; It seems like home manager's gtk pulling and old one:

dr-xr-xr-x  4 root root 4,0K  1. Jan 1970  c7v4c69m0cqic46w2a7n5v70fbqix5ad-nordic-2.2.0-unstable-2024-01-20
-r--r--r--  1 root root 5,7K  1. Jan 1970  dfq5h8qx5ix0qx0nvqgf5lfih50pyx6d-nordic-unstable-2023-10-17.drv
dr-xr-xr-x  4 root root 4,0K  1. Jan 1970  gcl45x248lmh84khaj6lvkbwb61rq7b9-nordic-unstable-2023-10-17
-r--r--r--  1 root root 5,7K  1. Jan 1970  h0jz51gmbbmhpdchahcp3vmbkzvglvhg-nordic-2.2.0-unstable-2024-01-20.drv
dr-xr-xr-x  4 root root 4,0K  1. Jan 1970  jjjiqkdnalmp9q9279233bc8zwib3rmg-nordic-unstable-2023-10-17
-r--r--r--  1 root root 5,7K  1. Jan 1970  ks7dbsq72q5x251z9iy6xcsg4pv5wil5-nordic-unstable-2023-10-17.drv
-r--r--r--  1 root root 5,7K  1. Jan 1970  pqk6qrz09dnvzz976gaxnkn4vcgwc45g-nordic-unstable-2023-10-17.drv
dr-xr-xr-x  4 root root 4,0K  1. Jan 1970  zbrwjrpdsjgsm7mp7xkx6xgv6jwnh5xf-nordic-unstable-2023-10-17E

With the config: image

Edit3: I made a workaround until figuring out packages: https://github.com/brumik/config/commit/8a113a346ebf7bca59370632c748eb30fd15123f#diff-558a02a936edbbeb00f882ca7aaf2eb4f962bd6f45eb9d4635b44363c9794bbb (this is dirty so use it on your own peril)

Cryolitia commented 5 months ago

Edit: I believe I have found the issue, if you take a look at the source for the nordic package in nixpkgs. it isn't even copying any gtk-4.0 folders over. I would assume this will cause issues for anyone using NixOS and the nordic package. I will attempt to fix this and then submit a pr to nixpkgs. https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/data/themes/nordic/default.nix

CC nixpkgs nordic maintainer @romildo

romildo commented 5 months ago

Edit: I believe I have found the issue, if you take a look at the source for the nordic package in nixpkgs. it isn't even copying any gtk-4.0 folders over. I would assume this will cause issues for anyone using NixOS and the nordic package. I will attempt to fix this and then submit a pr to nixpkgs. https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/data/themes/nordic/default.nix

CC nixpkgs nordic maintainer @romildo

The nordic package in nixpkgs copies everything (including the gtk-4.0 folder) from the master branch of the upstream nordic and nordic polar repositories: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/data/themes/nordic/default.nix#L96. Afterwards it deletes the source files that are not needed, leaving the same files one can find in the themes distributed in https://www.pling.com/p/1267246/

The gtk4-0 directory is there:

$ ls -l /run/current-system/sw/share/themes/Nordic/gtk-4.0
total 512
-r-xr-xr-x 1 root root 258455 dez 31  1969 gtk.css
-r-xr-xr-x 1 root root 258460 dez 31  1969 gtk-dark.css
lrwxrwxrwx 1 root root     24 dez 31  1969 thumbnail.png -> ../gtk-3.0/thumbnail.png

$ tar -Jtvf /tmp/Nordic.tar.xz Nordic-v40/gtk-4.0      # downloaded from pling
drwxr-xr-x eliverlara/eliverlara 0 2024-01-28 18:40 Nordic-v40/gtk-4.0/
-rwxr-xr-x eliverlara/eliverlara 258455 2024-01-28 18:40 Nordic-v40/gtk-4.0/gtk.css
-rwxr-xr-x eliverlara/eliverlara 258460 2024-01-28 18:40 Nordic-v40/gtk-4.0/gtk-dark.css
-rw-r--r-- eliverlara/eliverlara   1787 2024-01-28 18:40 Nordic-v40/gtk-4.0/thumbnail.png

Remember that currently there is no automatic way for setting a particular gtk-4.0 theme. The user should link the desired gtk-4.0 theme files and assets to the ~/.config directory:

$ ln -s /run/current-system/sw/share/themes/Nordic/gtk-4.0/* ~/.config/gtk-4.0/
$ ln -s /run/current-system/sw/share/themes/Nordic/assets ~/.config/

As I do not use home-manager to manage user configuration files, I can not help with it.