search

EliverLara / Sweet

Light and dark colorful Gtk3.20+ theme
https://www.gnome-look.org/p/1253385/
GNU General Public License v3.0
1.41k stars 89 forks source link

Theme Doesn't Apply To Status Bar and Some Panels #235

Closed AhmetFarukDemir closed 1 year ago

AhmetFarukDemir commented 1 year ago

Theme doesn't apply to status bar or some panels. Theme works on apps just as expected. Is this normal? I'm using sweetdark theme Screenshot from 2023-05-08 12-31-09 Screenshot from 2023-05-08 12-30-42 Screenshot from 2023-05-08 12-30-35 Screenshot from 2023-05-08 12-30-26

Coder2195Text commented 1 year ago

https://extensions.gnome.org/extension/19/user-themes/

If you are using 23.04 it will not work due to imcopability with gnome 44

https://askubuntu.com/questions/1464716/upgraded-to-23-04-and-issues-with-shell-themes

EliverLara commented 1 year ago

HI @AhmetFarukDemir It seems your not even using the gnome-shell theme, please make sure you set the correct theme by using the user themes extension and download the latest version released on gnome-look

D3vil0p3r commented 1 year ago

HI @AhmetFarukDemir It seems your not even using the gnome-shell theme, please make sure you set the correct theme by using the user themes extension and download the latest version released on gnome-look

I downloaded Sweet-Dark-v40.tar.xz latest version from gnome-look but I have graphic flickering on Sweet Dark theme after the upgrade to GNOME 44 when I open windows or terminals (like kitty): image

EliverLara commented 1 year ago

@Coder2195Text for libadwaita compatibility please try using this script, also as an advice in order to the theme affect apps that requires sudo permission you must install the your themes under /usr/share/hemes

EliverLara commented 1 year ago

@D3vil0p3r Could you provide more info about your OS please?

D3vil0p3r commented 1 year ago

@D3vil0p3r Could you provide more info about your OS please?

Sure. My OS is a Arch-based OS called Athena OS:

Linux zen kernel: 6.3.1-zen1-1-zen GNOME Shell version: 44.1 Display Manager: GDM

I'm running it on a Virtual Machine with 3D Acceleration enabled.

The issue occurs both on Xorg and Wayland. I reproduced the issue by opening kitty terminal window.

I'm also noting that, on GDM (Login Manager), if I click on top-right power button, Sweet theme is not applied, but I dont know if it is wanted: image

EliverLara commented 1 year ago

@D3vil0p3r Have you noticed if the issue only occurs with the sweet theme or it's also happening with other themes? The GDM theming is normal because this theme does not privide a theme for Gdm.

D3vil0p3r commented 1 year ago

@D3vil0p3r Have you noticed if the issue only occurs with the sweet theme or it's also happening with other themes? The GDM theming is normal because this theme does not privide a theme for Gdm.

Now I tested on Tokyo Night (that is still not updated for GNOME 44) and I get a worse behavior: image

Then I tested with a theme that has been upgraded for GNOME 44, Graphite, and it works correctly: image

AhmetFarukDemir commented 1 year ago

HI @AhmetFarukDemir It seems your not even using the gnome-shell theme, please make sure you set the correct theme by using the user themes extension and download the latest version released on gnome-look

Thank You! It worked. Everything seems fine.

D3vil0p3r commented 1 year ago

Hey @EliverLara I see that you updated the Sweet Dark v40 file, but I'm still getting the same issue I posted above.

Also according to the tests with other GTK themes of other devs, I'm noting that the issue occurs for those GTK windows developed by Python. For example, if I use SweetDark theme and I open GNOME Terminal (that should not be developed by GTK Python), I get the correct behavior: image

If I open a GTK window developed by Python, for example Kitty terminal, I get the weird behavior: image

Those strange white elements on the weird line on top of Kitty are "a part" of the GNOME top bar.

I'm discussing the same issue also here on different GTK themes: https://github.com/Fausto-Korpsvart/Tokyo-Night-GTK-Theme/issues/35

Just note that Sweet-Dark-v40 seems to work correcty on Wayland but not on Xorg.

Tell me if it is needed I open a new issue for this.

EliverLara commented 1 year ago

@D3vil0p3r sorry I haven't had so much time to reproduce the issue in a similar enviroment like yours , but could it be an approach to find the root problem? I think it could be kind of related https://github.com/EliverLara/Ant/issues/42

D3vil0p3r commented 1 year ago

@D3vil0p3r sorry I haven't had so much time to reproduce the issue in a similar enviroment like yours , but could it be an approach to find the root problem? I think it could be kind of related EliverLara/Ant#42

@EliverLara Uhm I'm not sure it could be related to that. About the reproducing don't worry, I give you all the details to reproduce it in a quick manner in a simple environment (Arch Linux original ISO). Here the steps:

  1. Download vanilla Arch Linux latest official ISO
  2. Create a Virtual Machine, i.e., by VMware, and mount the Arch Linux ISO mentioned above
  3. Run archinstall command for running Arch Linux installation. Among the selections, select GNOME as Desktop Environment. I also selected linux-zen as kernel but I think it is irrilevant
  4. After the installation of Arch Linux, login on the installed system, download Sweet-Dark-v40.tar.xz from Gnome Look and extract it by unxz Sweet-Dark-v40.tar.xz and then tar -xvf Sweet-Dark-v40.tar.
  5. Install kitty terminal for testing Sweet theme, by sudo pacman -Syy kitty
  6. Copy Sweet Dark theme to the theme folder by sudo cp -rf $HOME/Downloads/Sweet-Dark-v40 /usr/share/themes/
  7. Go to "Show Apps" image
  8. Search for Tweaks --> Appearance --> Legacy Applications --> set "Sweet-Dark-v40"
  9. Log out or reboot the machine
  10. When you reach the Login Screen and click on your username, it is VERY IMPORTANT that you click on the gear icon on bottom-right part of the screen and select GNOME for Xorg. Click there, and then insert your password for login, in order to work in the Xorg environment.
  11. Go to "Show Apps", search the Kitty icon and click on that: image
  12. You will get the weird behaviour: image

This bug occurs only on Xorg, but not on Wayland, and I noted that occurs at least for all Python GTK application windows.

EliverLara commented 1 year ago

@D3vil0p3r Could you test if replacing the Sweet/gtk-4.0/gtk.css file with this one fixes the issue. please?

D3vil0p3r commented 1 year ago

@D3vil0p3r Could you test if replacing the Sweet/gtk-4.0/gtk.css file with this one fixes the issue. please?

I replaced /usr/share/themes/Sweet-Dark-v40/gtk-4.0/gtk.css with that new file, then I executed ln -sf /usr/share/themes/Sweet-Dark-v40/gtk-4.0/gtk.css ./.config/gtk-4.0/gtk.css and then I reboot, and now the issue has been fixed, so that new gtk.css file you provided me fixed the issue.

Will it be added on Sweet-Dark-v40.zip file on GNOME Look website, right? When a new release will be created on GitHub repo with all these updates?

Thank you @EliverLara

EliverLara commented 1 year ago

Will it be added on Sweet-Dark-v40.zip file on GNOME Look website, right? When a new release will be created on GitHub repo with all these updates?

Yes. I'll adopt it as the official solution and release it on gnome-look and here in github, it's kind of funny since the issue was just a value in the window shadow :sweat_smile: by the way your profile's readme looks so cool.

D3vil0p3r commented 1 year ago

Thank you :)