EliverLara / candy-icons

:lollipop: Sweet gradient icons
https://www.opendesktop.org/p/1305251/
GNU General Public License v3.0
1.1k stars 118 forks source link

Only inherit themes which are really needed #582

Open alexxcons opened 5 months ago

alexxcons commented 5 months ago

Hi candy-icon team,

now that the related xdg merge request got merged and v0.18 of the spec got released, I am starting my mission to get the "Inherits" attribute right for popular icon-themes to prevent potentially missing icons 🙂

Currently candy-icon has:

Inherits=breeze-dark,Adwaita,hicolor

I wonder why breeze-dark and Adwaita are listed here ... is candy-icon lacking fd.org icons which need to be provided by these?

If there is no strong reason to keep them in the Inherits list, I would suggest dropping them.

If one/some of the other themes need to stay on the list for some reason, it makes sense to have a section in the README.md to explain packagers that the candy-icon-theme package should have a hard dependency on the other listed themes.