search

EliverLara / terminator-themes

:metal: The biggest collection of themes for Terminator terminal.
GNU General Public License v3.0
1.15k stars 100 forks source link

Theme installation error on Terminator 2.1.2 #45

Closed salimsket closed 1 year ago

salimsket commented 1 year ago

Terminator version: 2.1.2

Getting this error in the logs:

Traceback (most recent call last):
  File "/home/USR/.config/terminator/plugins/terminator-themes.py", line 253, in on_install
    self.terminal.config.add_profile(target["name"])
TypeError: Config.add_profile() missing 1 required positional argument: 'toclone'

Adding None at the end seems to fix it.

self.terminal.config.add_profile(target["name"], None)

After that, getting next error:

Traceback (most recent call last):
  File "/home/USR/.config/terminator/plugins/terminator-themes.py", line 266, in on_install
    self.config_base.set_item(k, v, target["name"])
  File "/usr/lib/python3.10/site-packages/terminatorlib/config.py", line 812, in set_item
    raise KeyError('ConfigBase::set_item: unknown key %s' % key)
KeyError: 'ConfigBase::set_item: unknown key cursor_color'

This quick dirty fix seems to work: image

tabcodes commented 1 year ago

FWIW- I tested the fix above with Terminator 2.1.2 on Linux Mint 21, and it worked like a charm. Thank you!

EliverLara commented 1 year ago

Thanks for pointing the error it was fixed with 2daa15e :)