Dockerfile changes - Githubissues

ElixirTeSS / TeSS

Training e-Support Service using Ruby on Rails.

Other

12 stars 12 forks source link

Dockerfile changes #853

Closed DaanVanVugt closed 1 year ago

DaanVanVugt commented 1 year ago

Summary of changes

While deploying our TeSS instance I ran into a problem wheret he assets precompile failed due to the database server not being available. The cleanest solution to that is to install sqlite3, but for that you need to have a built docker image (and the commands in the readme do not result in a changed gemfile.lock).

This work builds upon #839 and should be reviewed after that.

[ ] memory db url in dockerfile + db:setup
[ ] unknown facets error (zz_hidden_filters)

Motivation and context

Screenshots

Checklist

[x] I have read and followed the CONTRIBUTING guide.
[x] I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree to license it to the TeSS codebase under the BSD license.

fbacall commented 1 year ago

Is this for a production deployment?

DaanVanVugt commented 1 year ago

Yes

On Thu, 25 May 2023, 11:31 Finn Bacall, @.***> wrote:

Is this for a production deployment?

— Reply to this email directly, view it on GitHub https://github.com/ElixirTeSS/TeSS/pull/853#issuecomment-1562587486, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIY2AVBO7S2X7ERCSYV53XH4RGFANCNFSM6AAAAAAYNVM5YY . You are receiving this because you authored the thread.Message ID: @.***>

fbacall commented 1 year ago

What was the exact error?

Was it compiling assets during the build of the image, or afterwards?

DaanVanVugt commented 1 year ago

During the build, and the error was something with public activity and no database connection being established (because it tries to connect to localhost PG)

On Thu, 25 May 2023, 12:48 Finn Bacall, @.***> wrote:

What was the exact error?

Was it compiling assets during the build of the image, or afterwards?

— Reply to this email directly, view it on GitHub https://github.com/ElixirTeSS/TeSS/pull/853#issuecomment-1562689063, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIY2AZUA75KOBRJ3NMXLTXH42GTANCNFSM6AAAAAAYNVM5YY . You are receiving this because you authored the thread.Message ID: @.***>

fbacall commented 1 year ago

That's odd, the database should not be necessary at all for asset compilation. I've not encountered this when building locally, and I also have a WIP branch that tests the build via GitHub actions: https://github.com/ElixirTeSS/TeSS/actions/runs/4851679270/jobs/8646849888#step:4:782