Closed bencomp closed 1 year ago
Describe the bug
In Taxila, events that are scraped from Leiden University Libraries' events page often have end dates that come before their start dates. These end dates are then updated daily, when the scraper runs, to set the scrape date as the end date.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expect that single-day events have the same start and end date.
Screenshots
This is an example listing of events, with one a series that has started but the others workshops that start and finish on the same day.
Desktop (please complete the following information):
Additional context
I think this relates to parse_dates in event_ingestion.rb, as the leiden_ingestor directly gets the start and end dates from parse_dates.
parse_dates
event_ingestion.rb
leiden_ingestor
I will take a look at it
It looks like this was fixed by #866. Thanks!
Describe the bug
In Taxila, events that are scraped from Leiden University Libraries' events page often have end dates that come before their start dates. These end dates are then updated daily, when the scraper runs, to set the scrape date as the end date.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expect that single-day events have the same start and end date.
Screenshots
This is an example listing of events, with one a series that has started but the others workshops that start and finish on the same day.
Desktop (please complete the following information):
Additional context
I think this relates to
parse_dates
inevent_ingestion.rb
, as theleiden_ingestor
directly gets the start and end dates fromparse_dates
.