ElixirTeSS / TeSS

Training e-Support Service using Ruby on Rails.
Other
12 stars 12 forks source link

Event end date is scrape date, even before start date #862

Closed bencomp closed 1 year ago

bencomp commented 1 year ago

Describe the bug

In Taxila, events that are scraped from Leiden University Libraries' events page often have end dates that come before their start dates. These end dates are then updated daily, when the scraper runs, to set the scrape date as the end date.

To Reproduce

Steps to reproduce the behavior:

  1. Go to content provider Universiteit Leiden in Taxila
  2. Observe that future events that do not span multiple days have today's date as the end date

Expected behavior

I expect that single-day events have the same start and end date.

Screenshots

This is an example listing of events, with one a series that has started but the others workshops that start and finish on the same day.

future-event-listing

Desktop (please complete the following information):

Additional context

I think this relates to parse_dates in event_ingestion.rb, as the leiden_ingestor directly gets the start and end dates from parse_dates.

mikesndrs commented 1 year ago

I will take a look at it

bencomp commented 1 year ago

It looks like this was fixed by #866. Thanks!