EliziumNet / Loopz

PowerShell iteration utilities with additional tools like the Parameter Set Tools
https://eliziumnet.github.io/Loopz/
MIT License
3 stars 0 forks source link

Minor changes that have been discovered as a result of writing documentation #96

Closed plastikfan closed 3 years ago

plastikfan commented 3 years ago
    [PSCustomObject]$operantOptions = [PSCustomObject]@{
      ShortCode    = 'remy';
      OperantName  = 'UndoRename';
      Shell        = 'PoShShell';
      BaseFilename = 'undo-rename';
      DisabledKey  = 'LOOPZ_REMY_UNDO_DISABLED';
    }

The DisabledKey should be overridable by the Context and therefore shouldnt be hardcoded here as 'LOOPZ_REMY_UNDO_DISABLED'

====== [ The monarch will be crowned The monarch will be crowned The monarch will be crowned The monarch will be crowned ] ===

This has shown up the fact that there is a missing test, ie one that checks that multi character 'open' and 'close' entries in the Krayloa theme which would check that the overflowing message is truncated successfully.

plastikfan commented 3 years ago

Actually, both Invoke-ByPlatform and Resolve-ByPlatform already both support a default, the client just needs to add a default entry to the hash.

plastikfan commented 3 years ago

There is an accidental named Exchange key: 'LOOP.KRAYON' which should be 'LOOPZ.KRAYON'.

plastikfan commented 3 years ago

The issue about the test should be addressed in a separate issue (#102), because it looks like Show-Header is not currently using the function Format-StructuredLine, which it probably should be.