Ella-e / pe

0 stars 0 forks source link

Error message for archive command doesn't match with the actual error. #8

Open Ella-e opened 5 months ago

Ella-e commented 5 months ago

If a student is already in the archive list, if the user tries to archive the student again, a warning message that the id is not in the entry is shown. However, the actual situation is that the student is already in the archive list. It would be better if the message could match the situation and report to the user that the student is already in the archived list, instead of say it is not in the entry.

image.png

nus-se-bot commented 5 months ago

Team's Response

I think it is intuitive to say that the studentId is not in the entry, because archive can only work on the persons list. I think it is understandable that the studentId specified is not in the entry as in the persons list.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]