Ellerbach / docfx-companion-tools

A suite of tools, pipelines templates to take the very best of DocFX
MIT License
64 stars 18 forks source link

Why don't you support .NET 7? #45

Closed bdovaz closed 7 months ago

bdovaz commented 7 months ago

.NET 8 has been released very recently and it is obvious but .NET 7 why not?

Everything that manages our pipeline targets .NET 7 and just for this tool I have to install the .NET 6 runtime.

Would you accept a PR that targets .NET 7 (and .NET 8 if you want)?

Thanks!

The error:

You must install or update .NET to run this application.

App: /home/ci/.dotnet/tools/DocLinkChecker
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '6.0.0' (x64)
.NET location: /home/ci/data/agent/_work/_tool/dotnet

The following frameworks were found:
  7.0.14 at [/home/ci/data/agent/_work/_tool/dotnet/shared/Microsoft.NETCore.App]
Ellerbach commented 7 months ago

How do you install the tool? It should be transparent if you have a more recent version installed.

bdovaz commented 7 months ago

Following README.md:

https://github.com/Ellerbach/docfx-companion-tools#dotnet-tool

Ellerbach commented 7 months ago

Then it should definitely work fine:

image

As you can see, .NET 7.0 installed, installing the tool thru dotnet tool and running it

Ellerbach commented 7 months ago

And work same way on a Linux box but you have to add the --roll-forward Major option:

image

More info here: https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet#rollforward

bdovaz commented 7 months ago

But you did not get the output from dotnet --list-runtimes.

I'm sure you have the .NET 6 runtime installed as well besides the .NET 7 runtime.

dotnet --version outputs (I think) the most recent version you have

Ellerbach commented 7 months ago

dotnet --version outputs (I think) the most recent version you have

Yes, you are correct. Now, for the Linux side, I only have 1:

image

Just use ~/.dotnet/tools/DocLinkChecker --roll-forward Major (adjust for the path if any) and you'll be good to go

Ellerbach commented 7 months ago

PR #46 created to bring clarification in the main README.

Let me know if this is clear enough.

bdovaz commented 7 months ago

That's very good clarification, thank you @Ellerbach