search

EllieKallmier / ppa_analysis

Updates and additions to Nick Gorman's MSAT-PPA tool for 24/7 PPA project
MIT License
0 stars 2 forks source link

poetry dependency conflixts #1

Open nick-gorman opened 6 months ago

nick-gorman commented 6 months ago

Currently installing with poetry isn't working because of two conflicts:

  1. pandas: ppa_analysis requires pandas = "^2.2.2" but the dependency nemed specifies pandas = "^1.2". The carrot notation only means nemed can use any version of pandas after 1.2 but 2.0 or greater. Therefore to use version 2 of pandas and nemed we would need to update to allow pandas version 2 or maybe even require version 2.
  2. mip-python now requires python = ">=3.7,<3.13" but nemed requires python = ">= 3.8, <4.0". I wouldn't think this would create a conflict if, say, using Python 3.11, but apparently, it does. I think to fix this we would need to change nemed. I think nemed requires this change to keep its poetry install process working anyway, so would be some good nemed maintenance to do.

@EllieKallmier @dylanjmcconnell If we want to ppa_analysis to fit into the existing CEEM nem tool ecosystem I think it makes sense to use poetry (like nempy, nemseer, and nemed. nemosis is the exception atm). And to use poetry we would need to make the above changes. Therefore, I'd vote we go ahead with making these changes, happy todo. What do you think?

EllieKallmier commented 6 months ago

@nick-gorman Happy for you to go ahead with those changes :)

nick-gorman commented 4 months ago

Update on this, because a new version of NEMED hasn't been published this fix won't work yet.

However, I've updated the requirements.txt and tested it with a fresh install, and that seems to be working, so can be the interim solution for installing, see the instructions in the README.