Concept Node filter

[ElliotTheRobot]

The following checks / filter on node creation, update or association have to be in place:

• a node cannot be a parent or child of itself
• a node cannot be the parent of a node who has itself as the child of that parent node
• nodes cannot be duplicate
• a node cannot have the same other node as parent and grandparent

[JarbasAI]

• check 1 is taken care off inside ContentNode
  • check 2 i think is not in place, but not sure it can happen, will make tests
  • check 3 is ensured on node creation, if node exists it is updated
  • check 4 is ensured, if we add an existing parent it will update gen

check 2 importance: Joanna has a parent of female, but female cannot have a parent of Joanna else it would form a closed loop

[JarbasAI]

test_ normal functioning output:

2017-04-05 14:00:21,855 - CLIClient - INFO - Speak: joana can be: 
2017-04-05 14:00:21,855 - CLIClient - INFO - Speak: wife from generation 1
2017-04-05 14:00:21,855 - CLIClient - INFO - Speak: joana is:
2017-04-05 14:00:21,855 - CLIClient - INFO - Speak: alive from generation 3
2017-04-05 14:00:21,861 - CLIClient - INFO - Speak: human from generation 1
2017-04-05 14:00:21,861 - CLIClient - INFO - Speak: female from generation 2
2017-04-05 14:00:21,861 - CLIClient - INFO - Speak: animal from generation 2

output when making joana a parent of human and human a parent of joana:

2017-04-05 14:01:27,437 - CLIClient - INFO - Speak: joana can be: 
2017-04-05 14:01:27,437 - CLIClient - INFO - Speak: human from generation 0
2017-04-05 14:01:27,438 - CLIClient - INFO - Speak: wife from generation 1
2017-04-05 14:01:27,438 - CLIClient - INFO - Speak: joana is:
2017-04-05 14:01:27,440 - CLIClient - INFO - Speak: alive from generation 3
2017-04-05 14:01:27,443 - CLIClient - INFO - Speak: female from generation 3
2017-04-05 14:01:27,449 - CLIClient - INFO - Speak: human from generation 3
2017-04-05 14:01:28,843 - CLIClient - INFO - Speak: animal from generation 2

There is no closed loop but generations childs and parents get messy, check must be enforced

[JarbasAI]

crawl strategies will ensure these tests when crawling depending on the crawling strategy and objective, closing issue for now

crawls ensure no loops even if they exist, if they exist this data may have meaning and should still be left there