Correcting code which calls deprecated method

EllisLab / ee-tuts-download-module

Example module used in the ExpressionEngine Developer module creation tutorial

http://expressionengine.com/user_guide/development/module_tutorial.html

14 stars 15 forks source link

Correcting code which calls deprecated method #6

Open filtoid opened 8 years ago

filtoid commented 8 years ago

The fix for this file came from here: https://github.com/EllisLab/ee-tuts-download-module/issues/2 and was correct apart from 'foreach ($array as $dir)' needing to be 'foreach ($upload_directories as $dir)'. This now appears to work on my local version.

kevincupp commented 8 years ago

Thanks, @filtoid! The whitespace changes kind of make it difficult to see what's actually changed, and also may make it more difficult to follow with all the blank lines removed. Is the only thing that needed changing the way upload directories are queried for? If so, are you able to only submit those changes?

filtoid commented 8 years ago

Ah right sorry, I just copy pasted the answer from the issue #2, it needed a little bit of a tweak to get it to run but I didn't actually write the bulk of it. I'm afraid I'm up against it at the moment with a deadline but will try to make just the changes the file needs which hopefully should make it more readable, when I have some time.