Base matchers - Githubissues

Ellisande / mockolate

Simple mocking framework for JS

MIT License

1 stars 3 forks source link

Base matchers #16

Closed msquare711 closed 8 years ago

msquare711 commented 8 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

What is the current behavior? (You can also link to an open relevant tickets here)

Current behavior includes matchers for exact object matching, and any object matching

What is the new behavior (if this is a feature change)?

New behavior adds the ability to add an 'anyString' matcher

Where should the reviewer start?

readme.js

This is how I tested it

Unit testing by mocha

Does this PR introduce a breaking change?

No

If yes:

[ ] Major version changed
Please check if the PR fulfills these requirements**
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[ ] Version changed by at least patch version

Ellisande commented 8 years ago

Tests are well written. Good job on the import/export syntax.

Ellisande commented 8 years ago

Ahh, and don't forget to add the matcher to the documentation: https://github.com/Ellisande/mockolate/blob/baseMatchers/README.md#matchers

Ellisande commented 8 years ago

@msquare711 this looks really solid, just update the README with the documentation for your matcher, and update the doc on the pull request and I'll accept it!

msquare711 commented 8 years ago

PR request notes and readme updated. Need info on versioning

Ellisande commented 8 years ago

@msquare711 at the command line npm version patch then do a push

Ellisande commented 8 years ago

@msquare711 bumped the version myself because I need to merge something else in and didn't want you to have to merge with that.