Then object - Githubissues

Ellisande / mockolate

Simple mocking framework for JS

MIT License

1 stars 3 forks source link

Then object #9

Closed Ellisande closed 8 years ago

Ellisande commented 8 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Refactor

What is the current behavior? (You can also link to an open relevant tickets here)

Then functionality is encapsulated inside the when object.

What is the new behavior (if this is a feature change)?

Then functionality is extracted to its own object.

Where should the reviewer start?

The then object.

This is how I tested it

Lots and lots of unit tests.

Does this PR introduce a breaking change?

Yes. Its backwards compatible with 1.x, but several methods have been deprecated pending removal. If yes:

[x] Major version changed
Please check if the PR fulfills these requirements**
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[x] Version changed by at least patch version