search

Ellpeck / ActuallyAdditions

A Minecraft Mod about lots of useful gadgets and things!
http://minecraft.curseforge.com/projects/actually-additions
MIT License
214 stars 99 forks source link

Storage Crate losing Inventory #1342

Open berni1212 opened 4 years ago

berni1212 commented 4 years ago

Minecraft 1.12.2 Actual Addition Version: 1.12.2-r151-2 Modpack: Dungeon Dragons and Space Shuttles

Issue: If you pickup a Small/Medium/Large Storage Crate with an Storage Crate Keeper Addon and items in it

and turn in Creative and you Sort your Inventory you lose the Content of the Whole Storage Crate

MorningSage commented 4 years ago

I may be mistaken, but it seems to me that this issue would be caused by the whatever inventory sorter mod you are using.

Can you give more details like what mod you are using to do the sorting and/or if it happens with any other sorting mod?

I’d test myself, but I’ve moved on to 1.16...

Gr3atsaga commented 3 years ago

I have noticed a similar issue, however with both version 1.12.2-r151-2 and 1.12.2-r152. If you simply pickup a storage crate with a keeper addon, or even use ctrl-click in creative to copy NBT data, placing the storage in survival is fine, but placing in creative mode will more than likely delete the items. It's very weird because there were some locations I could place the crate in proximity to its original location and the items would still be there... but only one time. Destroying the container and then trying to place it again, the items were just gone no matter how many times I placed it in the same location or anywhere else.

It may definitely be due to a sorting mod or something. I have been playing MC Eternal, and the functionality was working just fine in MC Eternal v1.3.7 and even some of the beta versions of v1.4 but not in the release version v1.4.3. They did upgrade the version of AA from 151-2 to 152, so I thought that might be the reason so I downgraded and tried again. But the problem is still there, but wasn't in the older version of the pack... so some other mod that got updated is the cause.

The sorting mod used by MC Eternal is InventoryTweaks, currently v1.63 - however that version hasn't changed between MC Eternal v1.3.17 to v1.4.3 so I don't believe that is the culprit. But I could be wrong, I just don't remember ever having this issue with placing the storage crate in creative mode before.

I have heavily used the storage crates with crate keeper in the past to transport items between worlds - especially when JEID/NEID is concerned because those mods seem to break a lot of other inventories from other various mods that can hold their contents replacing them. Never seen this issue until now.

Could it be a newer version of Forge is the issue? They upgraded forge from v2847 to v2855 with the v1.4.3 update of MC Eternal, perhaps this is the same for DDSS?

MichaelHillcox commented 3 years ago

This is likely a forge bug with how they handle storage caps. I can have a look at it but no promises for 1.12