search

Ellpeck / Coroutine

A simple implementation of Unity's Coroutines to be used for any C# project
https://www.nuget.org/packages/Coroutine
MIT License
37 stars 3 forks source link

Added a unit test to expose an exception #14

Closed zaafar closed 3 years ago

zaafar commented 3 years ago

okay. MR is ready from my side.

zaafar commented 3 years ago

there are multiple possible solution I can think of.

1: Over here add the evt back into the Coroutine. It's harmless due to the if condition here

2: Over here do not depend on Coroutine event. Pass that separately (maybe a structure or a class or etc).

3: Coroutine save the history i.e. which event it moved from.

zaafar commented 3 years ago

actually (1) will not work, ignore that.

zaafar commented 3 years ago

Just tested it and everything is looking good. thanks! @Ellpeck .