Ellpeck / ObsidianCustomFrames

An Obsidian plugin that turns web apps into panes using iframes with custom styling. Also comes with presets for Google Keep, Todoist and more.
MIT License
585 stars 30 forks source link

Icon Display not working #117

Closed rk-kontur closed 8 months ago

rk-kontur commented 8 months ago

I cannot make the custom frame dsplay any icon. I tried full links to my icon folder, only Lucide names or just typing inside the little settings window. Nothing so far worked out.

Am I doing something wrong? Where are the icons supposed to be and what does the properly filled out field look like?

THANK YOU!

Ellpeck commented 8 months ago

Hi! None of the icons are supposed to be anywhere, you just have to type in the name of the Lucide icon.

For example, you can use the text calendar to display the calendar icon.

Keep in mind that you might have to restart Obsidian for your icon changes to take effect.

rk-kontur commented 8 months ago

Huh!

Thanks for getting back, but this is exactly what I tried. I even went so far as to look up the Lucide names on the weblink.

Could it be that I am keeping thhe icons in a dedicated folder set through iconize plugin?

https://github.com/FlorianWoelki/obsidian-iconize

Animation

After restart and disabling Minimal theme, this is what it looks like:

image

Ellpeck commented 8 months ago

Hi! That shouldn't really make a difference. Have you tried disabling the Obsidian theme you're using? It might be interfering with Obsidian's default set of Lucide icons.

rk-kontur commented 8 months ago

Also, there is no autocomplete when filling in. That is what I tried to show by deleting the last letter in the gif

Ellpeck commented 8 months ago

There isn't meant to be any autocomplete, as Obsidian doesn't provide a full list of the Lucide icons it supports.

Please try without any themes or snippets enabled :) Also, please keep in mind that you may have to restart Obsidian for your icon changes to take effect, as previously stated.

rk-kontur commented 8 months ago

All snippets disabled. Theme switched to Standard. REstarted

image

EDIT: Sorry. Forgot Auto-Theme-Switch Plugin. Kicked in while screenshotting. Now disabled. Standard Theme sticks.

Ellpeck commented 8 months ago

How many distinct icons have you tried with? Maybe the one you're trying to use just isn't supported by Obsidian :(

rk-kontur commented 8 months ago

Do you have one that you can confirm working? Otherwise there are quite a few to try.

Apart from that, I never had icon trouble elsewhere...

Ellpeck commented 8 months ago

All the icons that the default frame templates use are confirmed to work, obviously. You can just create a frame from one of the default templates in the Custom Frames settings, or you can see the full list of templates and their settings in this repo.

rk-kontur commented 8 months ago

Ok. Presets work. Which brings me to another point: Maybe you can provide a preset for TicTick? I see that it's widely used in Obsidian community

The link is

https://ticktick.com/webapp/#q/today/tasks

EDIT: How do I delete frames I do not need?

Ellpeck commented 8 months ago

Hm, that's a little annoying. There used to pretty much be community consensus that Obsidian supported all Lucide icons up to a specific version, along with some of its own icons. Back when I originally made the plugin, I just tried a bunch of randomly selected icons from the Lucide catalog, and they all worked, so I must've just been lucky then.

I'll make sure to change the wording of the icon section to point out that some icons might not work!

As for the preset: I generally only create presets for apps I use myself, since a big part of the presets is that they usually contain custom styling to make the site work better in the context of Obsidian (like removing unnecessary elements, and making sites that usually aren't made for a narrow layout work in the Obsidian sidebar. If you use the site frequently, feel free to create and submit a template via a pull request! There's more info about that in the README :)