Cleanup commands on plugin unload

ElmCast / elm-vim

Elm plugin for Vim

BSD 3-Clause "New" or "Revised" License

572 stars 102 forks source link

Cleanup commands on plugin unload #157

Closed jesse-c closed 6 years ago

jesse-c commented 6 years ago

Fixes #123. Possible better solution than #144.

Thank you @tpope and others for explaining the issue and fix.

Tested on macOS 10.13.4 with Vim (8.0.1750) and Neovim (0.2.2).

mdxprograms commented 6 years ago

@jesse-c I think this is definitely a cleaner fix than my previous one! Would you mind removing my additional exclamations on master branch if you haven't already and adding to your changes to make sure my additions don't conflict? Not sure they would or if my changes could have more potential for issues down the road, but if they aren't needed by adding your fix I'd rather remove what I had in there in this PR while submitting your fix. Nice work btw

jesse-c commented 6 years ago

@mdxprograms my understanding from what tpope and the others were saying is that your changes shouldn't be necessary. I've updated the branch to revert them :) And thanks! But all credit goes to the others pointing out the solution, I just did the implementation

mdxprograms commented 6 years ago

lgtm