ElmCast / elm-vim

Elm plugin for Vim
BSD 3-Clause "New" or "Revised" License
572 stars 102 forks source link

Support for Elm 0.19 #161

Closed Parasrah closed 6 years ago

Parasrah commented 6 years ago

As 0.19 was just released, was wondering what steps I need to take to get this plugin working properly. Thanks in advance! :smile:

jschomay commented 6 years ago

I'm wondering that too! I just ran into it. For the most part, everything just works. After updating my global versions of elm and elm-format, the few issues that I have come across are:

Parasrah commented 6 years ago

Did you have to create aliases for the old commands to map to the new commands (ex: elm-make -> elm make)? This might alleviate some of the issues until everything is patched

jschomay commented 6 years ago

Hmm, I did not do that. But the more that I think about it, my main usage is just ale linting and formatting, both of which didn't need any changes.

On Thu, Aug 23, 2018, 9:29 AM Brad notifications@github.com wrote:

Did you have to create aliases for the old commands to map to the new commands (ex: elm-make -> elm make)? This might alleviate some of the issues until everything is patched

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/ElmCast/elm-vim/issues/161#issuecomment-415480579, or mute the thread https://github.com/notifications/unsubscribe-auth/ABva04nPbsSX8tNwHLHu7MW00qN8Deuvks5uTthUgaJpZM4WI1AL .

Parasrah commented 6 years ago

Cool thanks! I appreciate knowing this will work to some degree before putting in the effort integrating it into my configuration!

1602 commented 6 years ago

It looks like json output format in elm 0.19 has been changed, here's example of new format being handled https://github.com/w0rp/ale/blob/master/ale_linters/elm/make.vim