ElmCast / elm-vim

Elm plugin for Vim
BSD 3-Clause "New" or "Revised" License
572 stars 102 forks source link

ElmMake output in 0.19 #163

Open ghost opened 6 years ago

ghost commented 6 years ago

I use heavily :ElmMake in conjunction with the quickfix list.

The output format of the compiler has changed in 0.19, so the parsing of the result fails and the quickfix list displays a single giant line ; and obviously fails to locate the errors in the files.

Are there plans to support 0.19 in that regard ?

Edit1: issue #161 brought that up but was closed In the comments was included this maybe-useful as an example of handling the new format https://github.com/w0rp/ale/blob/master/ale_linters/elm/make.vim

jschomay commented 6 years ago

As an alternative option, you could use ALE to catch compile errors. It can use the quick fix window, but also has inline indicators and some other nice features.

On Thu, Sep 13, 2018, 7:15 AM Syllogie notifications@github.com wrote:

I use heavily :ElmMake in conjunction with the quickfix list.

The output format of the compiler has changed in 0.19, so the parsing of the result fails and the quickfix list displays a single giant line ; and obviously fails to locate the errors in the files.

Are there plans to support 0.19 in that regard ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ElmCast/elm-vim/issues/163, or mute the thread https://github.com/notifications/unsubscribe-auth/ABva0ykwfxDLReQEjrbb--yEaVrI6BJQks5uamiQgaJpZM4WnWEC .

ghost commented 6 years ago

Yes, I looked at ALE and it seems really interesting.
I posted this issue because it seems to me that elm-vim cannot avoid compatibility with 0.19 for that feature. But I am definitely not going to wait very long for this upgrade to happen, this feature is at the core of my workflow. Thanks for the advice !

carmonw commented 5 years ago

I'm not a vimscript expert but I have made some changes in my fork (https://github.com/carmonw/elm-vim) to add support for elm 0.19 for the following things:

- ElmMake
- Syntastic
- `gf` hotkey and the linkage between elm modules

Hope this helps!