search

ElmCast / elm-vim

Elm plugin for Vim
BSD 3-Clause "New" or "Revised" License
572 stars 102 forks source link

fix elm make command to utilize the new elm make rather than elm-make #168

Closed ckipp01 closed 3 years ago

ckipp01 commented 5 years ago

I figured I'd send this in to start a discussion. There are still some of the commands that don't work right yet because they are still relying on the old style of calling them. Specifically the ElmMakeMain and ElmRepl. Either way, I'd like to fully address #164.

I didn't know if you'd prefer those to all be in separate PR's and I wasn't positive if you wanted backwards compatibility if someone is using an old version of Elm. Either way, I'm happy to do seperate PR's, one large PR and to make a stab at making it backwards compatible as well.

:+1:

bukzor commented 4 years ago

Please to merge.

mkinoshi commented 4 years ago

Is there any reason we are not merging this change yet?

williamhgough commented 3 years ago

Looking forward to this merge 🙏