EloBuddy / EloBuddy.Issues

Issue Tracker for
http://EloBuddy.net
0 stars 2 forks source link

IsRooted !? #69

Open LXMedia1 opened 8 years ago

LXMedia1 commented 8 years ago

Hat noch bis vor 2 std. perfect funktioniert.

nu bekomm ich immer false

var ImmobileUnits2 = EntityManager.Heroes.Enemies.Where(u => u.IsValidTarget(Spell.Range + Spell.Radius)); // todo add Channeling for specific Spells
                foreach (var unit in ImmobileUnits2)
                {
                    foreach (var buff in unit.Buffs)
                    {
                        if (Orbwalker.ActiveModesFlags.HasFlag(Orbwalker.ActiveModes.Combo))
                            Console.WriteLine(unit.ChampionName + ": " + buff.Name + " is stunned: " +(unit.HasBuffOfType(BuffType.Stun ) || unit.IsRooted || unit.IsStunned || !unit.CanMove || unit.IsTaunted));
                    }
                }

http://puu.sh/nxkOw/764174617a.png

Wie du siehst hat er aber den Morgana Binding Buff.

LXMedia1 commented 8 years ago

http://puu.sh/nxl5s/67298de3a2.png

beim R stunn funktionierts dürfte also das IsRooted sein welches nicht mehr klappt.

LXMedia1 commented 8 years ago

Dafür ist nun IsTaunted immer true ...

jachicao commented 8 years ago

use HasBuffType

LXMedia1 commented 8 years ago

i also checked
Console.WriteLine("Stun:" + ": " + unit.HasBuffOfType(BuffType.Stun)); Console.WriteLine("Snare:" + ": " + unit.HasBuffOfType(BuffType.Snare)); Console.WriteLine("Suppression:" + ": " + unit.HasBuffOfType(BuffType.Suppression));

it not work at all, only thing what would work is HasBuff( buffname ) but its not the goal to make this just couse a bug.

ghost commented 8 years ago

https://github.com/Alweul/EloBuddy/blob/master/GenesisAlistar/GenesisAlistar/Modes/PermaActive.cs#L26-L36

Code works fine for me, I always ult on root/stun/snare

LXMedia1 commented 8 years ago

i belive you that this code works for you, but i dont know if it works today couse i not tested till now, but yesterday was IsRooted bugged couse always false and IsTaunt always true, i report here bugs and dont ask how to make a work around ( i allready have a working workarround ) but this issue system is to report bugs.

ghost commented 8 years ago

You said "Its not work at all" and "only thing what would work is HasBuff( buffname )"

I showed you that I had working code for the past week and here is some additional info: No one has ever complained once that there were random R's, and no other plugin broke that uses the same code.

You want to report bugs, fine, report bugs that you have full proof exist, not code that works for others but not you.

Also: unit can be null in your code and a null unit will have incorrect results for any method or field called on it because its reference is null. Please always include output and expected output so that your report will be identifiable and not have 100 fake issues and 1 real one.

Sidenote: Yes, isRooted is broken, but when you are told use "x" instead and then you say it is broken when it is not, yes I am going to post proof that its not broken.

LXMedia1 commented 8 years ago

unit.HasBuffOfType(BuffType.Snare) also not work for Morgana Q thats what i wrote ... and i do not care if Player.HasBuffOfType(BuffType.Fear) || Player.HasBuffOfType(BuffType.Silence) || Player.HasBuffOfType(BuffType.Snare) || Player.HasBuffOfType(BuffType.Stun) || Player.HasBuffOfType(BuffType.Charm) || Player.HasBuffOfType(BuffType.Blind) || Player.HasBuffOfType(BuffType.Taunt) will work for morgana Q

couse Morgana Q is a snare / roor and and if the checks for this spells not work its a bug.

LXMedia1 commented 8 years ago

AND Player.HasBuffOfType(BuffType.Silence) Player.HasBuffOfType(BuffType.Charm) Player.HasBuffOfType(BuffType.Blind) Player.HasBuffOfType(BuffType.Fear) are not spells bufftypes what i wanna have, so if one of them goes true on a root its still a bug.

ghost commented 8 years ago

Then your issue is that the buff morganaqsnare or whatever its named does not activate the boolean values BuffType properly, not that HasBuffOfType doesn't work. Please reference the correct issue instead of saying that HasBuffOfType isn't working when it is.

LXMedia1 commented 8 years ago

Hellsing is german i wrote in the first post it not work for Morgana Binding Buff. (DarkBindingMissile)

ghost commented 8 years ago
  1. I can also read (not speak/write) a lot of german, I know what you said.
  2. I responded to your 4th post, not your first, and in that post, as I quoted, you said: "it not work at all, only thing what would work is HasBuff( buffname )" Which sounds like your saying "HasBuffofType does not work at all" which is completely untrue.
LXMedia1 commented 8 years ago

it not work at all for Morgana Q ... read/understand all and not just pick a part out of the contex